openshift / machine-config-operator

Apache License 2.0
244 stars 396 forks source link

[release-4.16] OCPBUGS-36198: daemon/update: disable systemd unit before overwriting #4436

Closed openshift-cherrypick-robot closed 3 weeks ago

openshift-cherrypick-robot commented 3 weeks ago

This is an automated cherry-pick of #4421

/assign jbtrystram

openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33694 has been cloned as Jira Issue OCPBUGS-36198. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-36198: daemon/update: disable systemd unit before overwriting

In response to [this](https://github.com/openshift/machine-config-operator/pull/4436): >This is an automated cherry-pick of #4421 > >/assign jbtrystram Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36198, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4436): >This is an automated cherry-pick of #4421 > >/assign jbtrystram Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jlebon commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@jlebon: This pull request references Jira Issue OCPBUGS-36198, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-33694](https://issues.redhat.com//browse/OCPBUGS-33694) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-33694](https://issues.redhat.com//browse/OCPBUGS-33694) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @sergiordlr

In response to [this](https://github.com/openshift/machine-config-operator/pull/4436#issuecomment-2191753238): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sdodson commented 3 weeks ago

/label staff-eng-approved

jbtrystram commented 3 weeks ago

/approve /backport-risk-assessed

djoshy commented 3 weeks ago

/approve /label backport-risk-assessed

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, jbtrystram, openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.16/OWNERS)~~ [djoshy,yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sergiordlr commented 3 weeks ago

/label cherry-pick-approved

jbtrystram commented 3 weeks ago

/retest

openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 69955305555571b075576711254c6657210b3be4 and 2 for PR HEAD cf9847e071f84452b0ac1d63b19a851afcd5b7e0 in total

openshift-ci[bot] commented 3 weeks ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upi-zones cf9847e071f84452b0ac1d63b19a851afcd5b7e0 link false /test e2e-vsphere-ovn-upi-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36198: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36198 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4436): >This is an automated cherry-pick of #4421 > >/assign jbtrystram Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202406270416.p0.g031dda5.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.

jbtrystram commented 3 weeks ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 3 weeks ago

@jbtrystram: new pull request created: #4441

In response to [this](https://github.com/openshift/machine-config-operator/pull/4436#issuecomment-2194231229): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-merge-robot commented 3 weeks ago

Fix included in accepted release 4.16.0-0.nightly-2024-06-27-091410