search

openshift / machine-config-operator

Apache License 2.0
245 stars 408 forks source link

OCPNODE-2357: templates/master/cri-o: make crun as the default container runtime #4437

Closed sohankunkerkar closed 1 month ago

sohankunkerkar commented 3 months ago

- What I did This commit sets crun as the default container runtime in OCP for 4.17

- How to verify it I'm in the process of adding test coverage for this behavior.

- Description for the changelog Make crun the default container runtime

kwilczynski commented 3 months ago

/approve /lgtm

rphillips commented 3 months ago

/hold going to hold until ACS signs off on this.

sohankunkerkar commented 2 months ago

/hold going to hold until ACS signs off on this.

We got confirmation from the ACS team to proceed with this change.

sohankunkerkar commented 2 months ago

/unhold /retest

haircommander commented 2 months ago

/approve /lgtm

haircommander commented 2 months ago

/approve cancel /lgtm cancel

waiting on one more piece from third party security scanners

haircommander commented 2 months ago

/retest

haircommander commented 1 month ago

/skip /approve

haircommander commented 1 month ago

/lgtm

openshift-ci-robot commented 1 month ago

@sohankunkerkar: This pull request references OCPNODE-2357 which is a valid jira issue.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4437): > > >**- What I did** >This commit sets `crun` as the default container runtime in OCP for 4.17 > >**- How to verify it** >I'm in the process of adding test coverage for this behavior. > >**- Description for the changelog** >Make crun the default container runtime > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rphillips commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski, rphillips, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[templates/master/01-master-container-runtime/OWNERS](https://github.com/openshift/machine-config-operator/blob/master/templates/master/01-master-container-runtime/OWNERS)~~ [haircommander] - ~~[templates/worker/01-worker-container-runtime/OWNERS](https://github.com/openshift/machine-config-operator/blob/master/templates/worker/01-worker-container-runtime/OWNERS)~~ [haircommander] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rphillips commented 1 month ago

/test unit

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 9c7a000be04738e98e4bae1709dad0b83af93113 and 2 for PR HEAD fd81685c582d60bbae324aab7fc05b251b3f78bc in total

sohankunkerkar commented 1 month ago

/retest

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 07d2cdaa0566d82591559916dcd9e84d13408fd0 and 1 for PR HEAD fd81685c582d60bbae324aab7fc05b251b3f78bc in total

sohankunkerkar commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@sohankunkerkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change fd81685c582d60bbae324aab7fc05b251b3f78bc link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn-upgrade-out-of-change fd81685c582d60bbae324aab7fc05b251b3f78bc link false /test e2e-aws-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
nee1esh commented 1 month ago

/test e2e-hypershift

haircommander commented 1 month ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 1 month ago

@haircommander: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4437#issuecomment-2277937753): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 month ago

@haircommander: new pull request created: #4518

In response to [this](https://github.com/openshift/machine-config-operator/pull/4437#issuecomment-2277937753): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator This PR has been included in build ose-machine-config-operator-container-v4.18.0-202408091844.p0.gda94f1b.assembly.stream.el9. All builds following this will include this PR.

sohankunkerkar commented 1 month ago

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

openshift-ci[bot] commented 1 month ago

@sohankunkerkar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b51fff50-5891-11ef-8230-5851bdfa9b4b-0