search

openshift / machine-config-operator

Apache License 2.0
245 stars 408 forks source link

OCPBUGS-30603: Bootstrap e2e test featuregate setup does not match the actual code #4439

Closed dkhater-redhat closed 3 months ago

dkhater-redhat commented 3 months ago

- What I did -added a function waitForFeatureGatesReady to handle the initialization and added necessary logging for debugging. -updated the runStartCmd function to wait for feature gates to be ready before starting controllers.

- How to verify it -run the bootstrap e2e tests located in test/e2e-bootstrap/bootstrap_test.go. -observe the logs to confirm that feature gates are initialized before controllers are started.

- Description for the changelog Ensure feature gates are initialized before starting controllers in the bootstrap process for the Machine Config Operator.

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-30603, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4439): > > >**- What I did** >-added a function waitForFeatureGatesReady to handle the initialization and added necessary logging for debugging. >-updated the runStartCmd function to wait for feature gates to be ready before starting controllers.* > >*- How to verify it** >-run the bootstrap e2e tests located in test/e2e-bootstrap/bootstrap_test.go. >-observe the logs to confirm that feature gates are initialized before controllers are started. >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 3 months ago

/test e2e-aws-ovn

sergiordlr commented 3 months ago

/test e2e-gcp-op-techpreview

dkhater-redhat commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-30603, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4439#issuecomment-2195237939): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-30603, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sergiordlr

In response to [this](https://github.com/openshift/machine-config-operator/pull/4439#issuecomment-2195239048): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 3 months ago

feel free to take a look at this! @QiWang19

umohnani8 commented 3 months ago

changes LGTM

dkhater-redhat commented 3 months ago

/retest

dkhater-redhat commented 3 months ago

/retest-required

sergiordlr commented 3 months ago

In the bootstrap e2e test cases logs https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_machine-config-operator/4439/pull-ci-openshift-machine-config-operator-master-bootstrap-unit/1806726663283675136/artifacts/test/build-log.txt

We can see the following logs

=== RUN TestE2EBootstrap/With_no_additional_manifests ... I0628 16:34:23.443237 17899 featuregates.go:27] Waiting for FeatureGates to be ready... ... I0628 16:34:24.443990 17899 featuregates.go:24] FeatureGates initialized: enabled=[AdminNetworkPol.... .. I0221 18:33:53.721502 17716 template_controller.go:233] Starting MachineConfigController-TemplateController ...

No errors found.

/label qe-approved

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [dkhater-redhat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dkhater-redhat commented 3 months ago

/test unit

openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD d37b0a60ca6c360e465635460173b7ec08f129e1 and 2 for PR HEAD 583ae9a24c4f492b6965219d38f3ae73eb746a26 in total

dkhater-redhat commented 3 months ago

/test e2e-hypershift

openshift-ci[bot] commented 3 months ago

@dkhater-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview 583ae9a24c4f492b6965219d38f3ae73eb746a26 link false /test e2e-gcp-op-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dkhater-redhat commented 3 months ago

/test e2e-hypershift

openshift-ci-robot commented 3 months ago

@dkhater-redhat: Jira Issue OCPBUGS-30603: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30603 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4439): > > >**- What I did** >-added a function waitForFeatureGatesReady to handle the initialization and added necessary logging for debugging. >-updated the runStartCmd function to wait for feature gates to be ready before starting controllers. > >**- How to verify it** >-run the bootstrap e2e tests located in test/e2e-bootstrap/bootstrap_test.go. >-observe the logs to confirm that feature gates are initialized before controllers are started. > >**- Description for the changelog** > Ensure feature gates are initialized before starting controllers in the bootstrap process for the Machine Config Operator. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202407032311.p0.gedfb19f.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.