search

openshift / machine-config-operator

Apache License 2.0
244 stars 396 forks source link

[release-4.15] OCPBUGS-36258: daemon/update: disable systemd unit before overwriting #4441

Closed openshift-cherrypick-robot closed 3 weeks ago

openshift-cherrypick-robot commented 3 weeks ago

This is an automated cherry-pick of #4436

/assign jbtrystram

openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36198 has been cloned as Jira Issue OCPBUGS-36258. Will retitle bug to link to clone. /retitle [release-4.15] OCPBUGS-36258: daemon/update: disable systemd unit before overwriting

In response to [this](https://github.com/openshift/machine-config-operator/pull/4441): >This is an automated cherry-pick of #4436 > >/assign jbtrystram Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36258, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4441): >This is an automated cherry-pick of #4436 > >/assign jbtrystram Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 weeks ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 55c0ad08c974565a556ecadd692b124a446103e6 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-vsphere-ovn 55c0ad08c974565a556ecadd692b124a446103e6 link false /test okd-scos-e2e-vsphere-ovn
ci/prow/okd-scos-e2e-aws-ovn 55c0ad08c974565a556ecadd692b124a446103e6 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp-op 55c0ad08c974565a556ecadd692b124a446103e6 link false /test okd-scos-e2e-gcp-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sdodson commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@sdodson: This pull request references Jira Issue OCPBUGS-36258, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36198](https://issues.redhat.com//browse/OCPBUGS-36198) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36198](https://issues.redhat.com//browse/OCPBUGS-36198) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

Requesting review from QA contact: /cc @sergiordlr

In response to [this](https://github.com/openshift/machine-config-operator/pull/4441#issuecomment-2196975559): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sdodson commented 3 weeks ago

/label backport-risk-assessed /label cherry-pick-approved /approve @jbtrystram just needs lgtm from you or someone else now

sdodson commented 3 weeks ago

/retest-required

openshift-ci[bot] commented 3 weeks ago

@sdodson: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to [this](https://github.com/openshift/machine-config-operator/pull/4441#issuecomment-2196979581): >/label backport-risk-assessed >/label cherry-pick-approved >/approve >@jbtrystram just needs lgtm from you or someone else now Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 weeks ago

@sdodson: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/machine-config-operator/pull/4441#issuecomment-2196979581): >/label backport-risk-assessed >/label cherry-pick-approved >/approve >@jbtrystram just needs lgtm from you or someone else now Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jbtrystram commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jbtrystram, openshift-cherrypick-robot, sdodson Once this PR has been reviewed and has the lgtm label, please assign cgwalters for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.15/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sdodson commented 3 weeks ago

/label approved

mike-nguyen commented 3 weeks ago

/label backport-risk-assessed /label cherry-pick-approved

openshift-ci[bot] commented 3 weeks ago

@mike-nguyen: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to [this](https://github.com/openshift/machine-config-operator/pull/4441#issuecomment-2197314461): >/label backport-risk-assessed >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 weeks ago

@mike-nguyen: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/machine-config-operator/pull/4441#issuecomment-2197314461): >/label backport-risk-assessed >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36258: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36258 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4441): >This is an automated cherry-pick of #4436 > >/assign jbtrystram Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.15.0-202406290108.p0.g98cf6fb.assembly.stream.el8 for distgit ose-machine-config-operator. All builds following this will include this PR.

openshift-merge-robot commented 3 weeks ago

Fix included in accepted release 4.15.0-0.nightly-2024-06-29-041418

jbtrystram commented 3 weeks ago

/cherry-pick release-4.14

openshift-cherrypick-robot commented 3 weeks ago

@jbtrystram: new pull request created: #4447

In response to [this](https://github.com/openshift/machine-config-operator/pull/4441#issuecomment-2198784031): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.