openshift / machine-config-operator

Apache License 2.0
244 stars 396 forks source link

[release-4.14] OCPBUGS-36356: daemon/update: disable systemd unit before overwriting #4447

Closed openshift-cherrypick-robot closed 2 weeks ago

openshift-cherrypick-robot commented 3 weeks ago

This is an automated cherry-pick of #4441

/assign jbtrystram

openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36258 has been cloned as Jira Issue OCPBUGS-36356. Will retitle bug to link to clone. /retitle [release-4.14] OCPBUGS-36356: daemon/update: disable systemd unit before overwriting

In response to [this](https://github.com/openshift/machine-config-operator/pull/4447): >This is an automated cherry-pick of #4441 > >/assign jbtrystram Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36356, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4447): >This is an automated cherry-pick of #4441 > >/assign jbtrystram Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jbtrystram commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@jbtrystram: This pull request references Jira Issue OCPBUGS-36356, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36258](https://issues.redhat.com//browse/OCPBUGS-36258) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36258](https://issues.redhat.com//browse/OCPBUGS-36258) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

Requesting review from QA contact: /cc @sergiordlr

In response to [this](https://github.com/openshift/machine-config-operator/pull/4447#issuecomment-2199794102): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sergiordlr commented 2 weeks ago

/label cherry-pick-approved

jbtrystram commented 2 weeks ago

/retest

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 5f5ce309c545f74888a748123dba0f8afbaccbd4 and 2 for PR HEAD 409eea7fdee56033abfd5d89c97289f297ffd5e0 in total

jlebon commented 2 weeks ago

CI was failing on

 Building github.com/openshift/machine-config-operator/cmd/machine-config-daemon (machine-config-daemon-4.6.0-202006240615.p0-2422-g4fd225c8-dirty, 4fd225c8b191b78c1bfa05bd5600532e04464cab) for linux/amd64
# github.com/openshift/machine-config-operator/pkg/daemon
pkg/daemon/file_writers.go:235:42: undefined: strings 

Tweaked the first patch to import the strings package in file_writers.go. That package was already being imported in newer releases.

yuqi-zhang commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.14/OWNERS)~~ [yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 5f5ce309c545f74888a748123dba0f8afbaccbd4 and 2 for PR HEAD e832fc05c057da691f23a3fad8deabb591975875 in total

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 442bca4ab0d6d054646f896b37ae0f6eafc8dee9 and 1 for PR HEAD e832fc05c057da691f23a3fad8deabb591975875 in total

jbtrystram commented 2 weeks ago

/retest

yuqi-zhang commented 2 weeks ago

Passed at least once /override ci/prow/e2e-hypershift

openshift-ci[bot] commented 2 weeks ago

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-hypershift

In response to [this](https://github.com/openshift/machine-config-operator/pull/4447#issuecomment-2207342840): >Passed at least once >/override ci/prow/e2e-hypershift Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36356 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4447): >This is an automated cherry-pick of #4441 > >/assign jbtrystram Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.14.0-202407040010.p0.g2af8f3e.assembly.stream.el8 for distgit ose-machine-config-operator. All builds following this will include this PR.