Closed openshift-cherrypick-robot closed 2 weeks ago
@openshift-cherrypick-robot: Jira Issue OCPBUGS-36258 has been cloned as Jira Issue OCPBUGS-36356. Will retitle bug to link to clone. /retitle [release-4.14] OCPBUGS-36356: daemon/update: disable systemd unit before overwriting
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36356, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
/jira refresh
@jbtrystram: This pull request references Jira Issue OCPBUGS-36356, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @sergiordlr
/label cherry-pick-approved
/retest
/retest-required
Remaining retests: 0 against base HEAD 5f5ce309c545f74888a748123dba0f8afbaccbd4 and 2 for PR HEAD 409eea7fdee56033abfd5d89c97289f297ffd5e0 in total
CI was failing on
Building github.com/openshift/machine-config-operator/cmd/machine-config-daemon (machine-config-daemon-4.6.0-202006240615.p0-2422-g4fd225c8-dirty, 4fd225c8b191b78c1bfa05bd5600532e04464cab) for linux/amd64
# github.com/openshift/machine-config-operator/pkg/daemon
pkg/daemon/file_writers.go:235:42: undefined: strings
Tweaked the first patch to import the strings
package in file_writers.go
. That package was already being imported in newer releases.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: openshift-cherrypick-robot, yuqi-zhang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD 5f5ce309c545f74888a748123dba0f8afbaccbd4 and 2 for PR HEAD e832fc05c057da691f23a3fad8deabb591975875 in total
/retest-required
Remaining retests: 0 against base HEAD 442bca4ab0d6d054646f896b37ae0f6eafc8dee9 and 1 for PR HEAD e832fc05c057da691f23a3fad8deabb591975875 in total
/retest
Passed at least once /override ci/prow/e2e-hypershift
@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-hypershift
@openshift-cherrypick-robot: Jira Issue OCPBUGS-36356 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
This PR has been included in build ose-machine-config-operator-container-v4.14.0-202407040010.p0.g2af8f3e.assembly.stream.el8 for distgit ose-machine-config-operator. All builds following this will include this PR.
This is an automated cherry-pick of #4441
/assign jbtrystram