search

openshift / machine-config-operator

Apache License 2.0
244 stars 396 forks source link

render: relax VIPs in infra status #4457

Closed EmilienM closed 1 week ago

EmilienM commented 1 week ago

In the context of Hypershift being deployed on the OpenStack platform, we have decided that Ingress on the workers would be out of scope in this release.

For that reason, we would like to relax the Infrastructure object where IPs don't have to be set for the API & Ingress VIPs.

VMware already allows that for their UPI and we need the same mechanism for now until we figure out how to handle Ingress VIPs on the workers and we can deploy Keepalived.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM Once this PR has been reviewed and has the lgtm label, please assign sinnykumari for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
EmilienM commented 1 week ago

/close Using userManaged LB did the trick, in the meantime I'll close it.

openshift-ci[bot] commented 1 week ago

@EmilienM: Closed this PR.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4457#issuecomment-2214986133): >/close >Using userManaged LB did the trick, in the meantime I'll close it. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.