search

openshift / machine-config-operator

Apache License 2.0
245 stars 408 forks source link

OCPBUGS-36711: templates: run disable-mglru conditionally #4459

Closed yuqi-zhang closed 2 months ago

yuqi-zhang commented 2 months ago

RHEL worker nodes may not have lru_gen, so adding a condition so it doesn't fail

openshift-ci-robot commented 2 months ago

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-36711, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4459): >RHEL worker nodes may not have lru_gen, so adding a condition so it doesn't fail Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yuqi-zhang commented 2 months ago

cc @rphillips @sdodson

sdodson commented 2 months ago

/lgtm

sdodson commented 2 months ago

/retest-required Looks like console.redhat.com outage based on the failures

openshift-ci[bot] commented 2 months ago

@yuqi-zhang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upi 42a2e797d697188cfeae168572c7b060487578ee link false /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yuqi-zhang commented 2 months ago

Hmm, the lgtm didn't seem to have applied

sdodson commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@yuqi-zhang: Jira Issue OCPBUGS-36711: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36711 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4459): >RHEL worker nodes may not have lru_gen, so adding a condition so it doesn't fail Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sdodson commented 2 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 2 months ago

@sdodson: new pull request created: #4462

In response to [this](https://github.com/openshift/machine-config-operator/pull/4459#issuecomment-2218618335): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202407092211.p0.g613885d.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.