search

openshift / machine-config-operator

Apache License 2.0
245 stars 409 forks source link

OCPBUGS-38321: Revert "templates/master/cri-o: make crun as the default container runtime" #4524

Closed neisw closed 2 months ago

neisw commented 2 months ago

Reverts #4518 ; tracked by https://issues.redhat.com/browse/OCPBUGS-38321

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

4.18/4.17 Disruption failures

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade-out-of-change
/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

CC: @sohankunkerkar

PR created by Revertomatic:tm:
openshift-ci-robot commented 2 months ago

@neisw: This pull request references OCPNODE-2357 which is a valid jira issue.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4524): > >Reverts #4518 ; tracked by https://issues.redhat.com/browse/OCPBUGS-38321 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >4.18/4.17 Disruption failures > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade-out-of-change >``` > >CC: @openshift-cherrypick-robot > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
neisw commented 2 months ago

/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade-out-of-change

openshift-ci[bot] commented 2 months ago

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0f0911d0-5808-11ef-9e30-50a5bd7943c6-0

neisw commented 2 months ago

/retitle OCPBUGS-38321: Revert "templates/master/cri-o: make crun as the default container runtime"

openshift-ci-robot commented 2 months ago

@neisw: This pull request references Jira Issue OCPBUGS-38321, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4524): > >Reverts #4518 ; tracked by https://issues.redhat.com/browse/OCPBUGS-38321 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >4.18/4.17 Disruption failures > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade-out-of-change >``` > >CC: @openshift-cherrypick-robot > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
neisw commented 2 months ago

/payload-job periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial

openshift-ci[bot] commented 2 months ago

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e44a1e20-5808-11ef-8bbf-0265e5c4152a-0

openshift-ci-robot commented 2 months ago

@neisw: This pull request references Jira Issue OCPBUGS-38321, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4524): >Reverts #4518 ; tracked by https://issues.redhat.com/browse/OCPBUGS-38321 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >4.18/4.17 Disruption failures > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade-out-of-change >``` > >``` >/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial >``` > >CC: @sohankunkerkar > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
neisw commented 2 months ago

The payload jobs confirm that the revert clears the disruption during node updates for the 'out-of-change' job as well as passes the aws-ovn-serial job that is permafailing in 4.17.

neisw commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@neisw: This pull request references Jira Issue OCPBUGS-38321, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4524#issuecomment-2283736767): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
neisw commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@neisw: This pull request references Jira Issue OCPBUGS-38321, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4524#issuecomment-2283741518): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
xueqzhan commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neisw, xueqzhan Once this PR has been reviewed and has the lgtm label, please assign nalind for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[templates/master/01-master-container-runtime/OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.17/templates/master/01-master-container-runtime/OWNERS)** - **[templates/worker/01-worker-container-runtime/OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.17/templates/worker/01-worker-container-runtime/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xueqzhan commented 2 months ago

/label approved

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD ae00dbdb3c94e54890acf6aec965039818df81ac and 2 for PR HEAD 7bfb4430e435dd72cb42be24e96c5f4db5f825d9 in total

deads2k commented 2 months ago

this is reverting the most recent change in 4.17. merging to unblock the org.

openshift-ci-robot commented 2 months ago

@neisw: Jira Issue OCPBUGS-38321: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38321 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4524): >Reverts #4518 ; tracked by https://issues.redhat.com/browse/OCPBUGS-38321 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >4.18/4.17 Disruption failures > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade-out-of-change >``` > >``` >/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial >``` > >CC: @sohankunkerkar > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@neisw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upi-zones 7bfb4430e435dd72cb42be24e96c5f4db5f825d9 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-vsphere-ovn-upi 7bfb4430e435dd72cb42be24e96c5f4db5f825d9 link false /test e2e-vsphere-ovn-upi
ci/prow/e2e-vsphere-ovn-zones 7bfb4430e435dd72cb42be24e96c5f4db5f825d9 link false /test e2e-vsphere-ovn-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator This PR has been included in build ose-machine-config-operator-container-v4.17.0-202408121444.p0.g801e9b6.assembly.stream.el9. All builds following this will include this PR.