search

openshift / machine-config-operator

Apache License 2.0
245 stars 409 forks source link

[release-4.17] OCPBUGS-38415: Give keepalived-monitor necessary capabilities #4532

Closed openshift-cherrypick-robot closed 2 months ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #4517

/assign rphillips

openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-37984 has been cloned as Jira Issue OCPBUGS-38415. Will retitle bug to link to clone. /retitle [release-4.17] OCPBUGS-38415: Give keepalived-monitor necessary capabilities

In response to [this](https://github.com/openshift/machine-config-operator/pull/4532): >This is an automated cherry-pick of #4517 > >/assign rphillips Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38415, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4532): >This is an automated cherry-pick of #4517 > >/assign rphillips Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
mkowalski commented 2 months ago

/lgtm

cybertron commented 2 months ago

/label backport-risk-assessed /cc @zhaozhanqi /cc @yuqi-zhang

This seems to be causing a lot of instability in the 4.17 payload jobs, so we'd like to get it merged ASAP.

mkowalski commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@mkowalski: This pull request references Jira Issue OCPBUGS-38415, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4532#issuecomment-2293066394): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
mkowalski commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@mkowalski: This pull request references Jira Issue OCPBUGS-38415, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-37984](https://issues.redhat.com//browse/OCPBUGS-37984) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-37984](https://issues.redhat.com//browse/OCPBUGS-37984) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/machine-config-operator/pull/4532#issuecomment-2293094225): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zhaozhanqi commented 2 months ago

pre-merge tested issue by checking the VIP located keepalived logs changed to 65

Fri Aug 16 09:11:09 2024: (sriov_API_0) Changing effective priority from 40 to 65
Fri Aug 16 09:11:39 2024: (sriov_API_0) Changing effective priority from 40 to 65

/label cherry-pick-approved /label qe-approved

openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38415, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-37984](https://issues.redhat.com//browse/OCPBUGS-37984) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-37984](https://issues.redhat.com//browse/OCPBUGS-37984) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/machine-config-operator/pull/4532): >This is an automated cherry-pick of #4517 > >/assign rphillips Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski, openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.17/OWNERS)~~ [yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 34406f7b9d5a7aa167234bcc9ebe1020702a356b and 2 for PR HEAD 3a00ca5de53c50d00c67c9e3298c91dd1c280c77 in total

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 120a89f42bfe1ec40748762fa6de1e3f3cf8bcdd and 1 for PR HEAD 3a00ca5de53c50d00c67c9e3298c91dd1c280c77 in total

mkowalski commented 2 months ago

/test e2e-aws-ovn-upgrade

openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upi-zones 3a00ca5de53c50d00c67c9e3298c91dd1c280c77 link false /test e2e-vsphere-ovn-upi-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cybertron commented 2 months ago

/retest-required

deads2k commented 2 months ago

/override ci/prow/e2e-gcp-op

openshift-ci[bot] commented 2 months ago

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-gcp-op

In response to [this](https://github.com/openshift/machine-config-operator/pull/4532#issuecomment-2299346654): >/override ci/prow/e2e-gcp-op Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-38415: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38415 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4532): >This is an automated cherry-pick of #4517 > >/assign rphillips Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD f30761f4c53ee05eab5d8887d8f4dfe7603cd20b and 0 for PR HEAD 3a00ca5de53c50d00c67c9e3298c91dd1c280c77 in total

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator This PR has been included in build ose-machine-config-operator-container-v4.17.0-202408201808.p0.gf30761f.assembly.stream.el9. All builds following this will include this PR.