search

openshift / machine-config-operator

Apache License 2.0
245 stars 409 forks source link

SPLAT-1765: bumping vendor support vSphere multi-nic #4538

Closed rvanderp3 closed 1 month ago

rvanderp3 commented 2 months ago

- What I did

- How to verify it CI job will be added and tested with the payload

- Description for the changelog Bumped vendor to pull in validation that allows more than one NIC for vSphere in the infrastructure spec.

Testing

Payload testing only incorporating vendor bump

Payload testing incorporating vendor bump and associated feature PRs

openshift-ci-robot commented 2 months ago

@rvanderp3: This pull request references SPLAT-1765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4538): >**- What I did** >Bumped vendor to pull in validation that allows more than one NIC in the infrastructure spec. > >**- How to verify it** >CI job will be added and tested with the payload > >**- Description for the changelog** >Bumped vendor to pull in validation that allows more than one NIC in the infrastructure spec. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot commented 2 months ago

@rvanderp3: This pull request references SPLAT-1765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4538): >**- What I did** >Bumped vendor to pull in validation that allows more than one NIC for vSphere in the infrastructure spec. > >**- How to verify it** >CI job will be added and tested with the payload > >**- Description for the changelog** >Bumped vendor to pull in validation that allows more than one NIC for vSphere in the infrastructure spec. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@rvanderp3: This PR was included in a payload test run from openshift/api#2002 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/34257110-63ee-11ef-8f61-6e16ee1eee00-0

openshift-ci[bot] commented 2 months ago

@rvanderp3: This PR was included in a payload test run from openshift/api#2002 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/43c9b480-646d-11ef-9fe7-bbafe4c35c40-0

openshift-ci[bot] commented 2 months ago

@rvanderp3: This PR was included in a payload test run from openshift/api#2002 trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci[bot] commented 2 months ago

@rvanderp3: This PR was included in a payload test run from openshift/api#2002 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6a5d4f50-656f-11ef-9c17-502935fd243c-0

openshift-ci[bot] commented 2 months ago

@rvanderp3: This PR was included in a payload test run from openshift/api#2002 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/06491b20-663c-11ef-96bd-22fc7463ddd9-0

openshift-ci[bot] commented 2 months ago

@rvanderp3: This PR was included in a payload test run from openshift/api#2002 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/111eb230-663c-11ef-9966-3e27599a85d3-0

openshift-ci[bot] commented 2 months ago

@rvanderp3: This PR was included in a payload test run from openshift/api#2002 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14d0bdb0-663c-11ef-93f9-8f76727ed066-0

openshift-ci[bot] commented 1 month ago

@rvanderp3: This PR was included in a payload test run from openshift/installer#8890 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4d8bd610-6acb-11ef-807f-0c92342b2826-0

openshift-ci[bot] commented 1 month ago

@rvanderp3: This PR was included in a payload test run from openshift/installer#8890 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9627c9b0-6acb-11ef-96bf-612acb492cad-0

openshift-ci[bot] commented 1 month ago

@rvanderp3: This PR was included in a payload test run from openshift/installer#8890 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9ae92250-6acb-11ef-9d10-33baa19d31ae-0

rvanderp3 commented 1 month ago

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-techpreview

openshift-ci[bot] commented 1 month ago

@rvanderp3: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f3fe9d70-6acb-11ef-8ef3-6b466f203f14-0

openshift-ci[bot] commented 1 month ago

@rvanderp3: This PR was included in a payload test run from openshift/installer#8890 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/17b20b50-6ad4-11ef-99d4-c7b0d0019c24-0

rvanderp3 commented 1 month ago

/hold

openshift-ci[bot] commented 1 month ago

@rvanderp3: This PR was included in a payload test run from openshift/installer#8890 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fae51ad0-6add-11ef-92d4-a91ff79b73a8-0

openshift-ci[bot] commented 1 month ago

@rvanderp3: This PR was included in a payload test run from openshift/installer#8890 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/43522450-6ae0-11ef-87c1-0bb68f0aeacd-0

openshift-ci[bot] commented 1 month ago

@rvanderp3: This PR was included in a payload test run from openshift/installer#8890 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0a3f2690-6af4-11ef-9a8d-b72183bf04a7-0

openshift-ci[bot] commented 1 month ago

@rvanderp3: This PR was included in a payload test run from openshift/installer#8890 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3679e160-6b8e-11ef-954e-334985b5eacc-0

openshift-ci[bot] commented 1 month ago

@rvanderp3: This PR was included in a payload test run from openshift/installer#8890 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/73a49b60-6ba8-11ef-967d-40442e1ca549-0

openshift-ci[bot] commented 1 month ago

@rvanderp3: This PR was included in a payload test run from openshift/installer#8890 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/60f2a050-6bb9-11ef-929e-9aa913e6b1b4-0

openshift-ci[bot] commented 1 month ago

@rvanderp3: This PR was included in a payload test run from openshift/installer#8890 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a7cdefd0-6bc7-11ef-937f-900ee73dbb8a-0

openshift-ci-robot commented 1 month ago

@rvanderp3: This pull request references SPLAT-1765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4538): >**- What I did** >Bumped vendor to pull in validation that allows more than one NIC for vSphere in the infrastructure spec. > >**- How to verify it** >CI job will be added and tested with the payload > >**- Description for the changelog** >Bumped vendor to pull in validation that allows more than one NIC for vSphere in the infrastructure spec. > >### Testing > >#### Payload testing only incorporating vendor bump >- [x] periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn: [f41d4569-335b-4bde-ba16-cabba4af6170](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-config-operator-4538-nightly-4.18-e2e-vsphere-ovn/1831342165557514240) >- [x] periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-techpreview: [3cef75ee-f452-4688-895e-3d153ffc263d](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-config-operator-4538-nightly-4.18-e2e-vsphere-ovn-techpreview/1831342166073413632) > >#### Payload testing incorporating vendor bump and associated feature PRs >- [x] periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-network: [b5cf064b-6068-4798-bc61-364e8bf514e1](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-config-operator-4538-openshift-machine-api-operator-1276-openshift-cluster-control-plane-machine-set-operator-323-openshift-installer-8890-nightly-4.18-e2e-vsphere-ovn-multi-network/1831795592557236224) >- [x] periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-techpreview: [61937e70-e43f-440a-8ea8-88c0b2be9e52](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-api-operator-1276-openshift-cluster-control-plane-machine-set-operator-323-openshift-machine-config-operator-4538-openshift-installer-8890-nightly-4.18-e2e-vsphere-ovn-techpreview/1831341316567470080) >- [x] periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn: [044829d5-3916-42fd-9b34-8d1bed65842b](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-config-operator-4538-openshift-machine-api-operator-1276-openshift-cluster-control-plane-machine-set-operator-323-openshift-installer-8890-nightly-4.18-e2e-vsphere-ovn/1831341722827755520) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rvanderp3 commented 1 month ago

/test unit

jcpowermac commented 1 month ago

/lgtm

openshift-ci-robot commented 1 month ago

@rvanderp3: This pull request references SPLAT-1765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4538): >**- What I did** >- Bumped vendor to pull in validation that allows more than one NIC for vSphere in the infrastructure spec. >- Dropped removed feature gates from tests. > >**- How to verify it** >CI job will be added and tested with the payload > >**- Description for the changelog** >Bumped vendor to pull in validation that allows more than one NIC for vSphere in the infrastructure spec. > >### Testing > >#### Payload testing only incorporating vendor bump >- [x] periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn: [f41d4569-335b-4bde-ba16-cabba4af6170](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-config-operator-4538-nightly-4.18-e2e-vsphere-ovn/1831342165557514240) >- [x] periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-techpreview: [3cef75ee-f452-4688-895e-3d153ffc263d](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-config-operator-4538-nightly-4.18-e2e-vsphere-ovn-techpreview/1831342166073413632) > >#### Payload testing incorporating vendor bump and associated feature PRs >- [x] periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-network: [b5cf064b-6068-4798-bc61-364e8bf514e1](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-config-operator-4538-openshift-machine-api-operator-1276-openshift-cluster-control-plane-machine-set-operator-323-openshift-installer-8890-nightly-4.18-e2e-vsphere-ovn-multi-network/1831795592557236224) >- [x] periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-techpreview: [61937e70-e43f-440a-8ea8-88c0b2be9e52](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-api-operator-1276-openshift-cluster-control-plane-machine-set-operator-323-openshift-machine-config-operator-4538-openshift-installer-8890-nightly-4.18-e2e-vsphere-ovn-techpreview/1831341316567470080) >- [x] periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn: [044829d5-3916-42fd-9b34-8d1bed65842b](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-config-operator-4538-openshift-machine-api-operator-1276-openshift-cluster-control-plane-machine-set-operator-323-openshift-installer-8890-nightly-4.18-e2e-vsphere-ovn/1831341722827755520) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rvanderp3 commented 1 month ago

/hold cancel

rvanderp3 commented 1 month ago

/assign @djoshy

openshift-ci[bot] commented 1 month ago

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 3febe3f694e1fbfbc32563f1b993d943cffdff25 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-vsphere-ovn-zones 3febe3f694e1fbfbc32563f1b993d943cffdff25 link false /test e2e-vsphere-ovn-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
djoshy commented 1 month ago

Payloads and e2es look good.

/approve /reteset-required

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, jcpowermac, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [djoshy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
djoshy commented 1 month ago

/retest-required

rvanderp3 commented 1 month ago

/retest-required

rvanderp3 commented 1 month ago

/test e2e-gcp-op