openshift / multi-operator-manager

experimental playspace
Apache License 2.0
3 stars 4 forks source link

Synthetic controller name annotation #32

Closed p0lyn0mial closed 4 weeks ago

p0lyn0mial commented 1 month ago

requires: https://github.com/openshift/library-go/pull/1867

p0lyn0mial commented 1 month ago

/hold

for https://github.com/openshift/library-go/pull/1867

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/multi-operator-manager/blob/master/OWNERS)~~ [p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
p0lyn0mial commented 1 month ago

/hold cancel

openshift-ci[bot] commented 1 month ago

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
p0lyn0mial commented 4 weeks ago

/close

in favour of https://github.com/openshift/multi-operator-manager/pull/35

openshift-ci[bot] commented 4 weeks ago

@p0lyn0mial: Closed this PR.

In response to [this](https://github.com/openshift/multi-operator-manager/pull/32#issuecomment-2454060059): >/close > >in favour of https://github.com/openshift/multi-operator-manager/pull/35 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.