search

openshift / multi-operator-manager

experimental playspace
Apache License 2.0
3 stars 4 forks source link

API-1835: sampleoperator: refactor controllers #44

Closed p0lyn0mial closed 2 weeks ago

p0lyn0mial commented 2 weeks ago

I’m planning to add more controllers to test double creation, deletion, and updates. For example: https://github.com/openshift/multi-operator-manager/pull/43/commits/5dceb6a8792d24de87c8ed3318865af37ec5998f

Having all controllers in one place improves maintainability.

openshift-ci-robot commented 2 weeks ago

@p0lyn0mial: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/multi-operator-manager/pull/44): >I’m planning to add more controllers to test double creation, deletion, and updates. >For example: https://github.com/openshift/multi-operator-manager/pull/43/commits/5dceb6a8792d24de87c8ed3318865af37ec5998f > >Having all controllers in one place improves maintainability. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmulti-operator-manager). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/multi-operator-manager/blob/master/OWNERS)~~ [p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).