search

openshift / multiarch-tuning-operator

An operator for managing workload placement in Openshift clusters with compute nodes of varying architectures
Apache License 2.0
4 stars 11 forks source link

Add the kubernetes.io/os selector too #46

Open aleskandro opened 6 months ago

aleskandro commented 6 months ago

In the future, it might be good for us to include the OS matchExpression too. it is a good piece of information that is also worth considering for the scheduler predicates.

For example, windows container images shouldn't "risk" landing into a linux node.

The current official recommendation (for OCP) is to leverage runtime classes that instruct the scheduler as a kind of 'side-effect'/additional feature, so it's just a "possible" future thing that we can onboard for free to consider better the platform information in the manifest list images we inspect

xref https://github.com/openshift/multiarch-manager-operator/pull/44#discussion_r1499492594

Prashanth684 commented 6 months ago

As we do more additions like this, we should start thinking when we want to expose our features with opt-in flags or options in the CR rather than doing it implicitly under the covers, like something along the lines of:

affinitySelector:
     - architecture
     - osType
     - custom
openshift-bot commented 3 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

aleskandro commented 3 months ago

/remove-lifecycle stale

openshift-bot commented 1 week ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale