openshift / must-gather-operator

Operator to enable CEE members to collect must-gathers from OSDv4 clusters
Apache License 2.0
8 stars 45 forks source link

Add secret key ref name to username and password env in upload container #140

Closed AlexVulaj closed 2 months ago

AlexVulaj commented 2 months ago

Fixes a bug that was missed in https://github.com/openshift/must-gather-operator/pull/138 - we weren't using the secret key ref name to properly reference username/password envars in the upload container.

Relevant slack thread: https://redhat-internal.slack.com/archives/C016S65RNG5/p1718723911684519

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.78%. Comparing base (44bbf4a) to head (f97aa15).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/must-gather-operator/pull/140/graphs/tree.svg?width=650&height=150&src=pr&token=UFO0L709WA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/must-gather-operator/pull/140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #140 +/- ## =========================================== + Coverage 7.83% 36.78% +28.95% =========================================== Files 5 5 Lines 383 386 +3 =========================================== + Hits 30 142 +112 + Misses 350 241 -109 Partials 3 3 ``` | [Files](https://app.codecov.io/gh/openshift/must-gather-operator/pull/140?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [controllers/mustgather/template.go](https://app.codecov.io/gh/openshift/must-gather-operator/pull/140?src=pr&el=tree&filepath=controllers%2Fmustgather%2Ftemplate.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-Y29udHJvbGxlcnMvbXVzdGdhdGhlci90ZW1wbGF0ZS5nbw==) | `87.50% <80.00%> (+87.50%)` | :arrow_up: |
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/must-gather-operator/blob/master/OWNERS)~~ [AlexVulaj,mjlshen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).