openshift / must-gather-operator

Operator to enable CEE members to collect must-gathers from OSDv4 clusters
Apache License 2.0
8 stars 45 forks source link

[SDCICD-1286] Set SSS mode to Upsert as prep for RVMO adoption #142

Closed mmazur closed 2 months ago

mmazur commented 2 months ago

Must Gather Operator is the first operator being switched from being deployed directly to hives using its own SelectorSyncSet to being deployed as part of the release bundle (managed-release-bundle-osd.git, SDE-3672).

First step is to switch the current SelectorSyncSet to Upsert mode, which will allow deleting the SelectorSyncSet entirely without Hives messing up any MGO deployments on clusters.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.75%. Comparing base (ffba798) to head (479addf). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/must-gather-operator/pull/142/graphs/tree.svg?width=650&height=150&src=pr&token=UFO0L709WA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/must-gather-operator/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #142 +/- ## ======================================= Coverage 37.75% 37.75% ======================================= Files 5 5 Lines 392 392 ======================================= Hits 148 148 Misses 241 241 Partials 3 3 ```
mmazur commented 2 months ago

/test validate

mmazur commented 2 months ago

/retest validate

openshift-ci[bot] commented 2 months ago

@mmazur: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/must-gather-operator/pull/142#issuecomment-2206030201): >/retest validate Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mmazur commented 2 months ago

/retest

mmazur commented 2 months ago

Seems something's wrong with prow, the test passed not long ago.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjlshen, mmazur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/must-gather-operator/blob/master/OWNERS)~~ [mjlshen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD ffba79880a54c003833686d35043c704500afe6a and 2 for PR HEAD 479addf1366f610eab1b6d194d73846ae26a718a in total

mmazur commented 2 months ago

/retest

openshift-ci[bot] commented 2 months ago

@mmazur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).