openshift / must-gather-operator

Operator to enable CEE members to collect must-gathers from OSDv4 clusters
Apache License 2.0
8 stars 45 forks source link

Fix operator build when setting up sshpass #156

Closed sam-nguyen7 closed 2 months ago

sam-nguyen7 commented 3 months ago

Fixes https://issues.redhat.com/browse/OSD-24888 where MGO image builds are currently failing with error error: Failed dependencies: libc.so.6(GLIBC_2.15)(64bit) is needed by sshpass-1.06-9.el8.x86_64 libc.so.6(GLIBC_2.2.5)(64bit) is needed by sshpass-1.06-9.el8.x86_64 libc.so.6(GLIBC_2.3.4)(64bit) is needed by sshpass-1.06-9.el8.x86_64 libc.so.6(GLIBC_2.4)(64bit) is needed by sshpass-1.06-9.el8.x86_64 Error: building at STEP "RUN microdnf install tar gzip openssh-clients wget shadow-utils procps && wget https://kojipkgs.fedoraproject.org/packages/sshpass/1.06/9.el8/x86_64/sshpass-1.06-9.el8.x86_64.rpm && rpm -U sshpass-1.06-9.el8.x86_64.rpm && rm -f sshpass-1.06-9.el8.x86_64.rpm && microdnf clean all": while running runtime: exit status 1

mmazur commented 3 months ago

/retest-required

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.75%. Comparing base (0061cc2) to head (c4b7fac). Report is 3 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/must-gather-operator/pull/156/graphs/tree.svg?width=650&height=150&src=pr&token=UFO0L709WA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/must-gather-operator/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #156 +/- ## ======================================= Coverage 37.75% 37.75% ======================================= Files 5 5 Lines 392 392 ======================================= Hits 148 148 Misses 241 241 Partials 3 3 ```
AlexVulaj commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, sam-nguyen7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/must-gather-operator/blob/master/OWNERS)~~ [AlexVulaj,sam-nguyen7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@sam-nguyen7: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mmazur commented 1 month ago

/cherrypick release-4.17

openshift-cherrypick-robot commented 1 month ago

@mmazur: new pull request created: #192

In response to [this](https://github.com/openshift/must-gather-operator/pull/156#issuecomment-2340787242): >/cherrypick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mmazur commented 1 month ago

/cherrypick release-4.16 release-4.15 release-4.14 release-4.13 release-4.12

openshift-cherrypick-robot commented 1 month ago

@mmazur: new pull request created: #206

In response to [this](https://github.com/openshift/must-gather-operator/pull/156#issuecomment-2342966914): >/cherrypick release-4.16 release-4.15 release-4.14 release-4.13 release-4.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.