openshift / must-gather-operator

Operator to enable CEE members to collect must-gathers from OSDv4 clusters
Apache License 2.0
8 stars 45 forks source link

[SDCICD-1286] Remove SSS file. #157

Closed mmazur closed 1 month ago

mmazur commented 1 month ago

No longer needed with the move to Release Bundle.

Also drop release branch builds enforcement from Makefile, as that's enforced at the appiface build level now.

mmazur commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

@mmazur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.75%. Comparing base (0061cc2) to head (4a0b33a).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/must-gather-operator/pull/157/graphs/tree.svg?width=650&height=150&src=pr&token=UFO0L709WA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/must-gather-operator/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #157 +/- ## ======================================= Coverage 37.75% 37.75% ======================================= Files 5 5 Lines 392 392 ======================================= Hits 148 148 Misses 241 241 Partials 3 3 ```
devppratik commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devppratik, mmazur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/must-gather-operator/blob/master/OWNERS)~~ [devppratik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mmazur commented 1 month ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 1 month ago

@mmazur: new pull request created: #158

In response to [this](https://github.com/openshift/must-gather-operator/pull/157#issuecomment-2262987620): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.