search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

OCPNODE-1499: Add CMA gather script #348

Closed jrvaldes closed 1 year ago

jrvaldes commented 1 year ago

This changes adds the gather script for the Custom Metrics Autoscaler (CMA) operator so that the operator resources are included in the must-gather if the operator is present.

Gathering the following:

openshift-ci-robot commented 1 year ago

@jrvaldes: This pull request references OCPNODE-1499 which is a valid jira issue.

In response to [this](https://github.com/openshift/must-gather/pull/348): >This changes adds the gather script for the Custom Metrics Autoscaler (CMA) operator so that the operator resources are included in the must-gather if the operator is present. > >Gathering the following: >- kedacontroller, >- scaledjob, >- scaledobject, >- triggerauthentication, >- clustertriggerauthentication and >- subscription namespace, e.g. ns/openshift-keda Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

jrvaldes commented 1 year ago

Sample output while collecting logs:

INFO: Waiting for openshift-custom-metrics-autoscaler-operator logs collection to complete ...
INFO: Processing kedacontroller: Wrote inspect data to must-gather.
INFO: Processing scaledjob: Wrote inspect data to must-gather.
INFO: Processing scaledobject: Wrote inspect data to must-gather.
INFO: Processing triggerauthentication: Wrote inspect data to must-gather.
INFO: Processing clustertriggerauthentication: Wrote inspect data to must-gather.
INFO: Processing ns/openshift-keda: Gathering data for ns/openshift-keda... Wrote inspect data to must-gather.
INFO: openshift-custom-metrics-autoscaler-operator logs collection completed

On the other hand, if the openshift-custom-metrics-autoscaler-operator subscription is not found in the cluster, the output is:

INFO: openshift-custom-metrics-autoscaler-operator not detected. Skipping.
jrvaldes commented 1 year ago

/CC @rphillips @joelsmith

rphillips commented 1 year ago

/lgtm /assign @soltysh

joelsmith commented 1 year ago

lgtm too, thanks @jrvaldes !

openshift-ci[bot] commented 1 year ago

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, RickJWagner, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [RickJWagner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jrvaldes commented 1 year ago

@RickJWagner , Do I need to backport this to include it in earlier must-gather releases? i.e. /cherry-pick release-4.12 for release-4.12

cc @joelsmith

jrvaldes commented 1 year ago

/cherry-pick release-4.12

As per conversation with Node Team, CMA log collection should be supported starting in 4.10.

openshift-cherrypick-robot commented 1 year ago

@jrvaldes: new pull request created: #349

In response to [this](https://github.com/openshift/must-gather/pull/348#issuecomment-1439061310): >/cherry-pick release-4.12 > >As per conversation with Node Team, CMA log collection should be supported starting in 4.10. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sferich888 commented 1 year ago

@RickJWagner / @jrvaldes can we re-visit (revert) this in light of the disucssion that happened in https://redhat-internal.slack.com/archives/CFDM5CQMN/p1677073218803299

jrvaldes commented 1 year ago

Documentation: