search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

Gather ostree related bits #353

Closed cgwalters closed 1 year ago

cgwalters commented 1 year ago

This has come up a lot, we should have had this from the start.

sferich888 commented 1 year ago

@cgwalters I don't have an issue with this; but do you understand that you will only get this from control plane nodes (by default). If your ok with that I can /lgtm this.

cgwalters commented 1 year ago

Ah, that does limit the utility a bit, but it's not fatal.

sferich888 commented 1 year ago

Your call on how to proceed.

cgwalters commented 1 year ago

We should definitely get this in because often the fatal error will affect the control plane too.

sferich888 commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, sferich888, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).