search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

Revert "NETOBSERV-987: Add must gather script for network observability" #360

Closed sferich888 closed 1 year ago

sferich888 commented 1 year ago

Reverts openshift/must-gather#357

openshift-ci-robot commented 1 year ago

@sferich888: This pull request references NETOBSERV-987 which is a valid jira issue.

In response to [this](https://github.com/openshift/must-gather/pull/360): >Reverts openshift/must-gather#357 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
RickJWagner commented 1 year ago

/LGTM

sferich888 commented 1 year ago

@RickJWagner / @davemulford I think this was merged by accident; thus reverting.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RickJWagner, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [RickJWagner,sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@sferich888: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sferich888 commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@sferich888: This pull request references NETOBSERV-987 which is a valid jira issue.

In response to [this](https://github.com/openshift/must-gather/pull/360#issuecomment-1529651146): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sferich888 commented 1 year ago

@msherif1234 we may need help progressing this through tide (we seem to need a bugzilla/valid-bug label) do you know what tool / linkage is necessary here to make that happen?

sferich888 commented 1 year ago

@mschmitt25414 did you manage to define a valid bug for this?

openshift-merge-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mschmitt25414 commented 1 year ago

@sferich888 'did you manage to define a valid bug for this?' - nope

sferich888 commented 1 year ago

@mschmitt25414 No I was looking for th original filer to do so.

msherif1234 commented 1 year ago

Did u try to use NETOBSERV-987 ?

sferich888 commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@sferich888: This pull request references NETOBSERV-987 which is a valid jira issue.

In response to [this](https://github.com/openshift/must-gather/pull/360#issuecomment-1633185460): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

ingvagabund commented 1 year ago

Closing in favor of https://github.com/openshift/must-gather/pull/390 /close

openshift-ci[bot] commented 1 year ago

@ingvagabund: Closed this PR.

In response to [this](https://github.com/openshift/must-gather/pull/360#issuecomment-1757615501): >Closing in favor of https://github.com/openshift/must-gather/pull/390 >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.