search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

OCPBUGS-14984: Collect Mellanox firmware information #365

Closed SalDaniele closed 1 year ago

SalDaniele commented 1 year ago

We need to be able to collect firmware specific information when Bluefield/Mellanox devices are being used with SRIOV.

This commit uses mstflint to add this information to the must-gather when such NICs are detected.

SalDaniele commented 1 year ago

cc @wizhaoredhat @bn222

SalDaniele commented 1 year ago

Hi @davemulford @sferich888. Is it possible to get this additional output added to the Must-gather?

wizhaoredhat commented 1 year ago

Very Nice! LGTM.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SalDaniele, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

@SalDaniele: This pull request references NHE-495 which is a valid jira issue.

In response to [this](https://github.com/openshift/must-gather/pull/365): >We need to be able to collect firmware specific information when Bluefield/Mellanox devices are being used with SRIOV. > >This commit uses mstflint to add this information to the must-gather when such NICs are detected. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@SalDaniele: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 year ago

@SalDaniele: This pull request references Jira Issue OCPBUGS-14984, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/must-gather/pull/365): >We need to be able to collect firmware specific information when Bluefield/Mellanox devices are being used with SRIOV. > >This commit uses mstflint to add this information to the must-gather when such NICs are detected. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
SalDaniele commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@SalDaniele: This pull request references Jira Issue OCPBUGS-14984, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/must-gather/pull/365#issuecomment-1591785789): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@SalDaniele: Jira Issue OCPBUGS-14984: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14984 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/must-gather/pull/365): >We need to be able to collect firmware specific information when Bluefield/Mellanox devices are being used with SRIOV. > >This commit uses mstflint to add this information to the must-gather when such NICs are detected. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.