openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

Split gather_network_logs into basics and extras #375

Closed flavio-fernandes closed 1 year ago

flavio-fernandes commented 1 year ago

With OVNK-Interconnect support in 4.14, ovnkube-nodes logs grew large. This commit adds the ability to either collect or skip the additional logs.

Script changes:

Reference: https://issues.redhat.com/browse/SDN-3733 Reported-at: https://issues.redhat.com/browse/SDN-3507

flavio-fernandes commented 1 year ago

/assign @npinaeva

flavio-fernandes commented 1 year ago

This PR should be merged after https://github.com/openshift/cluster-network-operator/pull/1938

flavio-fernandes commented 1 year ago

/retest-required

flavio-fernandes commented 1 year ago

/retest-required

flavio-fernandes commented 1 year ago

@npinaeva I uploaded the MG here: https://drive.google.com/drive/folders/1eXyp_wJ5-VoiDKaZv8xg4cMgFOHM_oH4?usp=drive_link

In the process, I hit an error I did not expect when using the mg images: no rsync! :( so I'm super glad you asked mt to try it because I was assuming it would work just as well outside the mg image. The drive with link above includes the commands I tried:

❯ oc adm must-gather --image=quay.io/ffernand/mg:${TAG} -- gather_network_logs 2>&1 | tee ~/collect.txt
❯ tar tzvf ./must-gather.loc*/quay-io-ffernan*/network_logs/ovnk_extras_store.tar.gz
openshift-ci[bot] commented 1 year ago

@flavio-fernandes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
npinaeva commented 1 year ago

/lgtm thanks @flavio-fernandes !

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, npinaeva, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment