search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

Collect running VMs count #382

Closed assafad closed 1 year ago

assafad commented 1 year ago

If Openshift Virtualization operator is installed, collect the number of running virtual machines in the cluster, across all namespaces.

Jira-ticket: https://issues.redhat.com/browse/CNV-32855

/cc @sradco, @soltysh

openshift-ci[bot] commented 1 year ago

Hi @assafad. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sradco commented 1 year ago

/lgtm

sradco commented 1 year ago

/ok-to-test

nunnatsa commented 1 year ago

/lgtm

sradco commented 1 year ago

/lgtm

sradco commented 1 year ago

/assign @davemulford

sradco commented 1 year ago

/retest-required

openshift-ci[bot] commented 1 year ago

@assafad: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: assafad, nunnatsa, sradco Once this PR has been reviewed and has the lgtm label, please ask for approval from davemulford. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sradco commented 1 year ago

After a lengthy discussion with Eric about the value of this PR vs the cost of maintaining it we both agree that the best possible option would be to figure out a way to dump the telemetry reported data (based on the discussion in this PR we already collect that information there) . There's also a similar PR (#372) which adds something similar, but which could be solved with this dump.

Hi @soltysh, We don't already collect this information.

assafad commented 1 year ago

After discussing the correct way to collect this information, it was decided to query Prometheus and collect the query result to MG. Closing in favor of https://github.com/openshift/must-gather/pull/384.