search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

OCPBUGS-24523: [release-4.12] Add csi-proxy logs collection in must-gather for Windows nodes #394

Closed jrvaldes closed 9 months ago

jrvaldes commented 11 months ago

This is a manual cherry-pick of https://github.com/openshift/must-gather/pull/374

openshift-ci-robot commented 11 months ago

@jrvaldes: This pull request references Jira Issue OCPBUGS-24523, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/must-gather/pull/394): >This is a manual cherry-pick of https://github.com/openshift/must-gather/pull/374 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jrvaldes commented 11 months ago

/jira refresh

openshift-ci-robot commented 11 months ago

@jrvaldes: This pull request references Jira Issue OCPBUGS-24523, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/must-gather/pull/394#issuecomment-1843324375): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jrvaldes commented 11 months ago

/jira refresh

openshift-ci-robot commented 11 months ago

@jrvaldes: This pull request references Jira Issue OCPBUGS-24523, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-19928](https://issues.redhat.com//browse/OCPBUGS-19928) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-19928](https://issues.redhat.com//browse/OCPBUGS-19928) targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z * bug has dependents

Requesting review from QA contact: /cc @rrasouli

In response to [this](https://github.com/openshift/must-gather/pull/394#issuecomment-1843332307): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 11 months ago

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sferich888 commented 11 months ago

/lgtm

rrasouli commented 11 months ago

/lgtm

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, rrasouli, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/release-4.12/collection-scripts/OWNERS)~~ [sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jrvaldes commented 11 months ago

/label backport-risk-assessed

openshift-ci[bot] commented 11 months ago

@jrvaldes: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/must-gather/pull/394#issuecomment-1845623494): >/label backport-risk-assessed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jrvaldes commented 11 months ago

@sferich888 could you help with /label backport-risk-assessed ?

jrvaldes commented 10 months ago

@sferich888 could you help with /label backport-risk-assessed ?

cc @RickJWagner

sferich888 commented 10 months ago

/label backport-risk-assessed

jrvaldes commented 10 months ago

/label cherry-pick-approved

openshift-ci[bot] commented 10 months ago

@jrvaldes: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/must-gather/pull/394#issuecomment-1877379361): >/label cherry-pick-approved > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rrasouli commented 9 months ago

/label cherry-pick-approved

openshift-ci[bot] commented 9 months ago

@rrasouli: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/must-gather/pull/394#issuecomment-1898698783): >/label cherry-pick-approved > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jrvaldes commented 9 months ago

@sferich888 I think this PR falls under the Backports Approvals in Repositories Where QE Does Not Verify Changes category.

Could you also help with /label cherry-pick-approved ?

cc @RickJWagner

mtnbikenc commented 9 months ago

@sferich888 @RickJWagner Following up on the request for /label cherry-pick-approved. We'd like to get this bug closed out this sprint and only have a few days left.

sferich888 commented 9 months ago

/label cherry-pick-approved

openshift-ci[bot] commented 9 months ago

@sferich888: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/must-gather/pull/394#issuecomment-1917780529): >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mtnbikenc commented 9 months ago

Based on this list the following users should be able to add the required cherry-pick-approved label. @kasturinarra @lihongan @zhouying7780 @xingxingxia

Also, it appears the repo is configured to add the cherry-pick-approved label when the backport-risk-assessed label is applied, however that didn't happen.

Any help in untangling this situation is greatly appreciated.

kasturinarra commented 9 months ago

Based on this list the following users should be able to add the required cherry-pick-approved label. @kasturinarra @lihongan @zhouying7780 @xingxingxia

Also, it appears the repo is configured to add the cherry-pick-approved label when the backport-risk-assessed label is applied, however that didn't happen.

Any help in untangling this situation is greatly appreciated.

sorry about that, adding it now.

kasturinarra commented 9 months ago

/label cherry-pick-approved

kasturinarra commented 9 months ago

/label cherry-pick-approved

@rrasouli since this is a backport and if you are unable to set the cherry-pick-approved label please help check the file here https://github.com/openshift/release/blob/master/core-services/prow/02_config/openshift/must-gather/_pluginconfig.yaml#L11-L18 (similar file is present for all openshift components, thanks !!) and do a @ on us so that we can add the same.

openshift-ci-robot commented 9 months ago

@jrvaldes: Jira Issue OCPBUGS-24523: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24523 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/must-gather/pull/394): >This is a manual cherry-pick of https://github.com/openshift/must-gather/pull/374 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 9 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-must-gather-container-v4.12.0-202401311148.p0.gdc23fd8.assembly.stream for distgit ose-must-gather. All builds following this will include this PR.

openshift-merge-robot commented 9 months ago

Fix included in accepted release 4.12.0-0.nightly-2024-01-31-124257