openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

NO-JIRA: Running gather scripts in background #399

Closed OdedViner closed 10 months ago

OdedViner commented 10 months ago

To save time when running the OCP MG, the collection scripts can be executed in parallel.

Process: 1.Collect script 2.Waiting on subprocesses to finish execution.

Tested on my cluster and we can save 20% run time:

oviner:my_image$ time oc adm must-gather --image=quay.io/oviner/ocs-must-gather:ocp_mg2
real    7m49.209s
user    0m13.960s
sys     0m4.095s

oviner:regular_image$ time oc adm must-gather --image=quay.io/openshift/origin-must-gather:latest 
real    9m44.340s
user    0m14.055s
sys 0m4.115s
openshift-ci[bot] commented 10 months ago

Hi @OdedViner. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
soltysh commented 10 months ago

/ok-to-test

openshift-ci[bot] commented 10 months ago

@OdedViner: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 10 months ago

@OdedViner: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/must-gather/pull/399): >To save time when running the OCP MG, the collection scripts can be executed in parallel. > >Process: >1.Collect script >2.Waiting on subprocesses to finish execution. > >Tested on my cluster and we can save 20% run time: >``` >oviner:my_image$ time oc adm must-gather --image=quay.io/oviner/ocs-must-gather:ocp_mg2 >real 7m49.209s >user 0m13.960s >sys 0m4.095s > > > >oviner:regular_image$ time oc adm must-gather --image=quay.io/openshift/origin-must-gather:latest >real 9m44.340s >user 0m14.055s >sys 0m4.115s >``` Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OdedViner, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 10 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-must-gather-container-v4.16.0-202401022050.p0.g4c685e0.assembly.stream for distgit ose-must-gather. All builds following this will include this PR.

sferich888 commented 10 months ago

Does this affect any of the logging out tracing that are possible today using the trace files?

OdedViner commented 10 months ago

Does this affect any of the logging out tracing that are possible today using the trace files?

Created private image quay.io/oviner/ocs-must-gather:ocp_mg2 I uploaded the mg dir https://url.corp.redhat.com/886dfba Can yu check it?