search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 186 forks source link

WRKLDS-950: use must-gather since and since time env vars on inspect cmds #400

Closed flavianmissi closed 8 months ago

openshift-ci-robot commented 8 months ago

@flavianmissi: This pull request references WRKLDS-950 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/must-gather/pull/400): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 8 months ago

LGTM. I'm deferring to @ingvagabund for another set of eyes.

flavianmissi commented 8 months ago

something is still off, holding until I figure it out /hold

flavianmissi commented 8 months ago

Checked that --since-time works for both node logs (under host_service_logs) and pod logs (under namespaces/.../pod/.../logs/current.log. --since is a little more complicated - when a duration is given from via the cli as 2h, after calling duration.String() it is formatted as 2h0m0s and oc adm node-logs does takes a duration matching the (+|-)[0-9]+(s|m|h|d) regex. I'm going to have to truncate the duration string to keep its left most part, so in the case of 2h0m0s only 2h would be given as an argument to oc adm node-logs.

flavianmissi commented 8 months ago

fixed format of duration given to oc adm node-logs. also using lowercase now for the non-env-vars, which seem to be the best practice. will be pushing the updates in a moment.

flavianmissi commented 8 months ago

Both flags now work as they should! /hold cancel

ardaguclu commented 8 months ago

/lgtm

zhouying7780 commented 8 months ago

/label qe-approved

openshift-ci-robot commented 8 months ago

@flavianmissi: This pull request references WRKLDS-950 which is a valid jira issue.

In response to [this](https://github.com/openshift/must-gather/pull/400): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
flavianmissi commented 8 months ago

@ardaguclu this one is ready to go in!

ardaguclu commented 8 months ago

Thanks @flavianmissi /lgtm

ardaguclu commented 8 months ago

/lgtm

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, flavianmissi, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 8 months ago

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-must-gather-container-v4.16.0-202401221510.p0.gc8fec85.assembly.stream for distgit ose-must-gather. All builds following this will include this PR.