search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 186 forks source link

[WIP] Dump Prometheus metrics #401

Closed sradco closed 4 months ago

sradco commented 8 months ago

We are adding a Prometheus metrics dump using the Prometheus promtool.

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sradco Once this PR has been reviewed and has the lgtm label, please assign rickjwagner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 8 months ago

@sradco: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sferich888 commented 5 months ago

@sradco / @soltysh can this be closed in-favor of https://github.com/openshift/must-gather/pull/398 or https://github.com/openshift/must-gather/pull/389

sradco commented 5 months ago

@sradco / @soltysh can this be closed in-favor of #398 or #389

Yes, from my POV it can be closed in-favor of #389. I believe #398 can also be closed in-favor of it.