search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

OPNET-470: Collect host networking logs #404

Open mkowalski opened 8 months ago

mkowalski commented 8 months ago

It happens very often that must-gather is the only bundle provided to the networking team when asking to help debugging various issues. In reality, in majority of those cases we would rather get sosreport and not must-gather because the former contains useful outputs from ip command.

With this PR we are trying to get the most basic networking informations already into must-gather to speed up debugging.

Contributes-to: OPNET-470 Contributes-to: OCPBUGS-26217 Contributes-to: OCPBUGS-29624

openshift-ci-robot commented 8 months ago

@mkowalski: This pull request references OPNET-470 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/must-gather/pull/404): >It happens very often that must-gather is the only bundle provided to the networking team when asking to help debugging various issues. In reality, in majority of those cases we would rather get sosreport and not must-gather because the former contains useful outputs from `ip` command. > >With this PR we are trying to get the most basic networking informations already into must-gather to speed up debugging. > >Contributes-to: [OPNET-470](https://issues.redhat.com//browse/OPNET-470) >Contributes-to: OCPBUGS-26217 >Contributes-to: OCPBUGS-29624 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 8 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot commented 8 months ago

@mkowalski: This pull request references OPNET-470 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/must-gather/pull/404): >It happens very often that must-gather is the only bundle provided to the networking team when asking to help debugging various issues. In reality, in majority of those cases we would rather get sosreport and not must-gather because the former contains useful outputs from `ip` command. > >With this PR we are trying to get the most basic networking informations already into must-gather to speed up debugging. > >Contributes-to: [OPNET-470](https://issues.redhat.com//browse/OPNET-470) >Contributes-to: OCPBUGS-26217 >Contributes-to: OCPBUGS-29624 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
mkowalski commented 8 months ago

/test all

mkowalski commented 8 months ago

/cc @cybertron

/cc @dgoodwin @stbenjam This is a closure on the last issues we were debugging. If we had this from the very beginning (i.e. inside must-gather and not only on the live system), we would have saved a bit of time

mkowalski commented 8 months ago

/test all

mkowalski commented 8 months ago

/test all

openshift-ci[bot] commented 8 months ago

@mkowalski: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cybertron commented 8 months ago

/lgtm

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cybertron, mkowalski Once this PR has been reviewed and has the lgtm label, please assign rickjwagner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sferich888 commented 1 month ago

@mkowalski are you still working this issue? Have you had a chance to look at my suggestions/recommendations and are we able to limit this in some way?

@ingvagabund this is another example where your comments (in https://github.com/openshift/must-gather/pull/416#issuecomment-2306584908) apply to more diligence in what we collect/pull in.