search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

NO-JIRA: Adding the missing clusterresourcequota and Flowcontrol resources #408

Closed vlours closed 4 months ago

vlours commented 7 months ago

PR following the RFE request #407

Added the resources in the group_resources array.

sferich888 commented 7 months ago

@soltysh who is the best person to review this? This looks fine to me to add; but I am not an expert in this space so It probably needs to be reviewed by the underlying team maintaining API Priority and Fairness

vlours commented 7 months ago

@sferich888 Thanks for checking on this one while I was away.

Do you think that I should create a Jira Ticket to draw attention on this PR? Cheers,

vlours commented 6 months ago

@sferich888 @davemulford Any chance for this PR to be reviewed? And do I need to create a valid Jira request too, as part of the needs?

Needs approved, jira/valid-reference, lgtm labels.

I did not created one, as the modification was just to add additional basic openshift components in the collection scripts. Please let me know how to get this PR moving forward. Thanks! 🙇

sferich888 commented 4 months ago

@vlours I am going to give the a lgtm as I don't see why we can't include this.

/lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sferich888, vlours

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sferich888 commented 4 months ago

/retitle NO-JIRA: Adding the missing clusterresourcequota and Flowcontrol resources

sferich888 commented 4 months ago

/retitle NO-JIRA: Adding the missing clusterresourcequota and Flowcontrol resources

openshift-ci-robot commented 4 months ago

@vlours: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/must-gather/pull/408): >PR following the RFE request #407 > >Added the resources in the `group_resources` array. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sferich888 commented 4 months ago

/retest

openshift-ci[bot] commented 4 months ago

@vlours: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).