search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 186 forks source link

OCPBUGS-31037: Collect PerformanceProfile Data From all Nodes #410

Closed max-i-mil closed 3 months ago

max-i-mil commented 5 months ago

Add toleration to perf-node-gather DaemonSet to ensure PerformanceProfile related data is collected from all nodes in a cluster.

The PerformanceProfileCreator tool, found within the Node Tuning Operator will return errors if the necessary files are missing for tainted cluster nodes. The data is collected using this DaemonSet in must-gather

Nodes are expected to be tainted for various reasons such as Infrastructure nodes, master nodes etc

openshift-ci[bot] commented 5 months ago

Hi @max-i-mil. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 5 months ago

@max-i-mil: This pull request references Jira Issue OCPBUGS-31037, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/must-gather/pull/410): >Add toleration to perf-node-gather DaemonSet to ensure PerformanceProfile related data is collected from all nodes in a cluster. > >The PerformanceProfileCreator tool, found within the Node Tuning Operator will return errors if the necessary files are missing for tainted cluster nodes. The data is collected using this DaemonSet in must-gather > >Nodes are expected to be tainted for various reasons such as Infrastructure nodes, master nodes etc Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
MarSik commented 5 months ago

/ok-to-test

MarSik commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@MarSik: This pull request references Jira Issue OCPBUGS-31037, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (aos-workloads-staff@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/must-gather/pull/410#issuecomment-2047223145): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
MarSik commented 5 months ago

/lgtm

MarSik commented 5 months ago

/retest

MarSik commented 3 months ago

/assign rickjwagner

RickJWagner commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, max-i-mil, RickJWagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [RickJWagner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

@max-i-mil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 months ago

@max-i-mil: Jira Issue OCPBUGS-31037: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31037 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/must-gather/pull/410): >Add toleration to perf-node-gather DaemonSet to ensure PerformanceProfile related data is collected from all nodes in a cluster. > >The PerformanceProfileCreator tool, found within the Node Tuning Operator will return errors if the necessary files are missing for tainted cluster nodes. The data is collected using this DaemonSet in must-gather > >Nodes are expected to be tainted for various reasons such as Infrastructure nodes, master nodes etc Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-must-gather-container-v4.17.0-202406070112.p0.g408ab86.assembly.stream.el9 for distgit ose-must-gather. All builds following this will include this PR.