search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

CNF-9168: MetalLB: adjust to support frrk8s and small fix #412

Closed fedepaol closed 6 months ago

fedepaol commented 7 months ago

This PR adjusts the must gather collect script to reflect the latest metallb:

Also, minor fix in fetching the pid from the right path.

oribon commented 7 months ago

/lgtm

fedepaol commented 7 months ago

@sferich888 @soltysh mind having a look here?

openshift-ci-robot commented 7 months ago

@fedepaol: This pull request references CNF-9168 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/must-gather/pull/412): >This PR adjusts the must gather collect script to reflect the latest metallb: > >- it checks for the bgp backend and collect from the frr-k8s / speaker frr container according to the bgp backend >- it removes fetching the addresspool resource that was removed > >Also, minor fix in fetching the pid from the right path. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
fedepaol commented 7 months ago

/jira refresh

openshift-ci-robot commented 7 months ago

@fedepaol: This pull request references CNF-9168 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/must-gather/pull/412#issuecomment-2051223713): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
soltysh commented 6 months ago

/tide merge-method-squash

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, oribon, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 6 months ago

@fedepaol: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).