search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 186 forks source link

MON-3754: Enable metrics-server audit log collection #413

Closed slashpai closed 5 months ago

slashpai commented 5 months ago

audit-logs are enabled by default on metrics-server in openshift/cluster-monitoring-operator#2280.

This change is to enable collection of metrics-server audit-log in must-gather.

cc: @simonpasquier @jan--f

openshift-ci-robot commented 5 months ago

@slashpai: This pull request references MON-3754 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/must-gather/pull/413): >audit-logs are enabled by default on metrics-server in openshift/cluster-monitoring-operator#2280. > >This change is to enable collection of metrics-server audit-log in must-gather. > >cc: @simonpasquier @jan--f Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jan--f commented 5 months ago

/lgtm

slashpai commented 5 months ago

Is this good to merge?

sferich888 commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, sferich888, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

@slashpai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-must-gather-container-v4.16.0-202404191609.p0.g0c4be17.assembly.stream.el8 for distgit ose-must-gather. All builds following this will include this PR.