search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

WRKLDS-1251: Use oc rhel8 binary explicitly until base image is rhel9 #418

Closed ardaguclu closed 6 months ago

ardaguclu commented 6 months ago

must-gather includes oc invocations to gather some data and must-gather gets this oc from cli image. However, when we try to bump cli image to RHEL9, since must-gather is still on RHEL8, all oc invocations failed. This PR changes to use cli-artifacts image instead of cli. Thanks to that change, must-gather can explicitly uses oc.rhel8 and that decouples the cli and must-gather images for the future similar migrations.

example failures;

openshift-ci-robot commented 6 months ago

@ardaguclu: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/must-gather/pull/418): >must-gather includes oc invocations to gather some data and must-gather gets this oc from cli image. However, when we try to bump cli image to RHEL9, since must-gather is still on RHEL8, all oc invocations failed. This PR changes to use cli-artifacts image instead of cli. Thanks to that change, must-gather can explicitly uses oc.rhel8 and that decouples the cli and must-gather images for the future similar migrations. > >example failures; > >* https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_oc/1752/pull-ci-openshift-oc-master-e2e-aws-ovn/1784837264291926016 >* https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_oc/1752/pull-ci-openshift-oc-master-e2e-agnostic-ovn-cmd/1784837260940677120 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 6 months ago

This PR depends on https://github.com/openshift/release/pull/51449/

sferich888 commented 6 months ago

While I don't like doing this; this is temporary (to work around SSL compatibility issue with FIPS across OCP versions).

/lgtm

ardaguclu commented 6 months ago

/hold until dependant merges

openshift-ci[bot] commented 6 months ago

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
joepvd commented 6 months ago

/lgtm

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, joepvd, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/must-gather/blob/master/OWNERS)~~ [sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ardaguclu commented 6 months ago

/hold cancel

openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-must-gather-container-v4.17.0-202404301246.p0.g68204b5.assembly.stream.el8 for distgit ose-must-gather. All builds following this will include this PR.