search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 186 forks source link

WRKLDS-1251: Use oc.rhel8 based on the target arch of image #420

Closed ardaguclu closed 4 months ago

ardaguclu commented 4 months ago

This PR uses the correct oc.rhel8 binary based on the image's architecture. This is the follow up of https://github.com/openshift/must-gather/pull/418

openshift-ci-robot commented 4 months ago

@ardaguclu: This pull request references WRKLDS-1251 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/must-gather/pull/420): >This PR uses the correct oc.rhel8 binary based on the image's architecture. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
joepvd commented 4 months ago

/lgtm

openshift-ci-robot commented 4 months ago

@ardaguclu: This pull request references WRKLDS-1251 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/must-gather/pull/420): >This PR uses the correct oc.rhel8 binary based on the image's architecture. This is the follow up of https://github.com/openshift/must-gather/pull/418 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jeffdyoung commented 4 months ago

/lgtm

sferich888 commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, jeffdyoung, joepvd, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/must-gather/blob/master/OWNERS)~~ [sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-must-gather-container-v4.16.0-202405021515.p0.gff904a4.assembly.stream.el8 for distgit ose-must-gather. All builds following this will include this PR.

jaypoulz commented 4 months ago

Should this have included s390x as well?