search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 186 forks source link

OCPBUGS-33959: Network logs collection: skip unready nodes #425

Closed martinkennelly closed 3 months ago

martinkennelly commented 3 months ago

Previous to this change, debug pods will be launched to node that are unready and deployment will not complete. Also update control plane label selector.

/cc ~/hold~

openshift-ci-robot commented 3 months ago

@martinkennelly: This pull request references Jira Issue OCPBUGS-33959, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/must-gather/pull/425): >Previous to this change, debug pods will be launched to node that are unready and deployment will not complete. >Also update control plane label selector. > >/cc >/hold Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

@martinkennelly: GitHub didn't allow me to request PR reviews from the following users: martinkennelly.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/must-gather/pull/425): >Previous to this change, debug pods will be launched to node that are unready and deployment will not complete. >Also update control plane label selector. > >/cc >/hold Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
martinkennelly commented 3 months ago

/unhold

testing complete

openshift-ci-robot commented 3 months ago

@martinkennelly: This pull request references Jira Issue OCPBUGS-33959, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/must-gather/pull/425): >Previous to this change, debug pods will be launched to node that are unready and deployment will not complete. >Also update control plane label selector. > >/cc >~/hold~ Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
martinkennelly commented 3 months ago

@soltysh PTAL - fix speeds up data collection for MGs when there NotReady CP nodes.

sferich888 commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martinkennelly, sferich888, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [sferich888,soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

@martinkennelly: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 months ago

@martinkennelly: Jira Issue OCPBUGS-33959: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33959 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/must-gather/pull/425): >Previous to this change, debug pods will be launched to node that are unready and deployment will not complete. >Also update control plane label selector. > >/cc >~/hold~ Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-must-gather-container-v4.17.0-202406052200.p0.gaad3357.assembly.stream.el9 for distgit ose-must-gather. All builds following this will include this PR.

abhat commented 2 weeks ago

/cherry-pick release-4.17 release-4.16 release-4.15

openshift-cherrypick-robot commented 2 weeks ago

@abhat: #425 failed to apply on top of branch "release-4.17":

Applying: Network logs collection: skip unready nodes
Using index info to reconstruct a base tree...
M   collection-scripts/gather_network_logs_basics
Falling back to patching base and 3-way merge...
Auto-merging collection-scripts/gather_network_logs_basics
CONFLICT (content): Merge conflict in collection-scripts/gather_network_logs_basics
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Network logs collection: skip unready nodes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/must-gather/pull/425#issuecomment-2329848474): >/cherry-pick release-4.17 release-4.16 release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.