OCPBUGS-43894: Avoids to collect frr.log for MetalLB

rh-fcristin commented 5 months ago

Entire frr.log files collected by the gather_metallb can be huge in size (several GB) and in case of clusters with a lot of nodes the must-gather size can grow easily to an unreasonable size to be shared. Part of the frr logs are already into the regular container logs, I believe that in case these logs are really needed for troubleshooting we can still ask for them.

I'm proposing here to remove the frr.log files collection from the gather_metallb script, this will drastically improve the size of the must-gather.

openshift-bot commented 2 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sferich888 commented 1 month ago

/lgtm

openshift-bot commented 3 weeks ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-ci-robot commented 2 weeks ago

@rh-fcristin: This pull request references Jira Issue OCPBUGS-43894, which is invalid:

expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/must-gather/pull/427): >Entire frr.log files collected by the gather_metallb can be huge in size (several GB) and in case of clusters with a lot of nodes the must-gather size can grow easily to an unreasonable size to be shared. >Part of the frr logs are already into the regular container logs, I believe that in case these logs are really needed for troubleshooting we can still ask for them. > >I'm proposing here to remove the frr.log files collection from the gather_metallb script, this will drastically improve the size of the must-gather. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 2 weeks ago

@rh-fcristin: This pull request references Jira Issue OCPBUGS-43894, which is invalid:

expected the bug to target the "4.14.z" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-43894 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/must-gather/pull/427): >Entire frr.log files collected by the gather_metallb can be huge in size (several GB) and in case of clusters with a lot of nodes the must-gather size can grow easily to an unreasonable size to be shared. >Part of the frr logs are already into the regular container logs, I believe that in case these logs are really needed for troubleshooting we can still ask for them. > >I'm proposing here to remove the frr.log files collection from the gather_metallb script, this will drastically improve the size of the must-gather. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 2 weeks ago

@rh-fcristin: This pull request references Jira Issue OCPBUGS-43894, which is invalid:

expected the bug to target the "4.17.z" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-43894 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/must-gather/pull/427): >Entire frr.log files collected by the gather_metallb can be huge in size (several GB) and in case of clusters with a lot of nodes the must-gather size can grow easily to an unreasonable size to be shared. >Part of the frr logs are already into the regular container logs, I believe that in case these logs are really needed for troubleshooting we can still ask for them. > >I'm proposing here to remove the frr.log files collection from the gather_metallb script, this will drastically improve the size of the must-gather. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

fedepaol commented 2 weeks ago

thanks for filing this!

fedepaol commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, rh-fcristin, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/release-4.17/collection-scripts/OWNERS)~~ [sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 2 weeks ago

@rh-fcristin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws	0d815e94fd3fb60c35ef6df448ab90d4081eeb60	link	true	`/test e2e-aws`
ci/prow/images	0d815e94fd3fb60c35ef6df448ab90d4081eeb60	link	true	`/test images`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift / must-gather

OCPBUGS-43894: Avoids to collect frr.log for MetalLB #427