search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

SDN-5066:Remove needless multus log collection #429

Closed martinkennelly closed 4 months ago

martinkennelly commented 4 months ago

Multus is now a Pod and will be captured by normal oc adm must-gather command.

The multus.log file is removed since 4.16 and doesn't exist anymore.

/hold

/cc

@dougbtv

openshift-ci[bot] commented 4 months ago

@martinkennelly: GitHub didn't allow me to request PR reviews from the following users: martinkennelly.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/must-gather/pull/429): >Multus is now a Pod and will be captured by normal oc adm must-gather command. > >The multus.log file is removed since 4.16 and doesn't exist anymore. > >/hold > >/cc > >@dougbtv Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
martinkennelly commented 4 months ago

Holding until I get multus team sign-off first.

openshift-ci[bot] commented 4 months ago

@martinkennelly: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dougbtv commented 4 months ago

/approve

dougbtv commented 4 months ago

/lgtm

dougbtv commented 4 months ago

This is indeed the correct course of action to take here. The gist is that the architecture of Multus CNI changed (in 4.14) to what we call a "thick plugin" architecture. Previously, Multus CNI, in operation, is a process that runs on the host, a one-shot process from a binary executed on the host (we call this a "thin plugin" architecture). Now, there is both that process, but additionally a daemon that runs in a Kubernetes pod. This pod has the log output, so the previous log collection is obsolete.

Thanks Martin!

bpickard22 commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bpickard22, dougbtv, martinkennelly Once this PR has been reviewed and has the lgtm label, please assign sferich888 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bpickard22 commented 4 months ago

/retitle SDN-5066:Remove needless multus log collection

openshift-ci-robot commented 4 months ago

@martinkennelly: This pull request references SDN-5066 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/must-gather/pull/429): >Multus is now a Pod and will be captured by normal oc adm must-gather command. > >The multus.log file is removed since 4.16 and doesn't exist anymore. > >/hold > >/cc > >@dougbtv Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
bpickard22 commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@bpickard22: This pull request references SDN-5066 which is a valid jira issue.

In response to [this](https://github.com/openshift/must-gather/pull/429#issuecomment-2182960694): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
bpickard22 commented 4 months ago

/approve

bpickard22 commented 4 months ago

/unhold

bpickard22 commented 4 months ago

/tide refresh

bpickard22 commented 4 months ago

/close

bpickard22 commented 4 months ago

going to attempt to close and re-open to get the approve label to apply

bpickard22 commented 4 months ago

ahh @martinkennelly we need someone from the mg owners to approve, @dougbtv and I cannot give that label

bpickard22 commented 4 months ago

/assign @sferich888 Hi Eric, would you mind approving this?

openshift-ci[bot] commented 4 months ago

@bpickard22: Closed this PR.

In response to [this](https://github.com/openshift/must-gather/pull/429#issuecomment-2196954692): >/close > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
bpickard22 commented 4 months ago

/open

sferich888 commented 4 months ago

/open

martinkennelly commented 4 months ago

/open