search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

SDN-5066,OCPBUGS-33959: Remove needless multus log collection #431

Closed martinkennelly closed 3 months ago

martinkennelly commented 4 months ago

Multus is now a Pod and will be captured by normal oc adm must-gather command.

The multus.log file is removed since 4.14 and doesn't exist anymore.

Previous PR is hung: https://github.com/openshift/must-gather/pull/429 Please see this PR for lgtm from multus team.

/assign @sferich888

openshift-ci-robot commented 4 months ago

@martinkennelly: This pull request references SDN-5066 which is a valid jira issue.

In response to [this](https://github.com/openshift/must-gather/pull/431): >Multus is now a Pod and will be captured by normal oc adm must-gather command. > >The multus.log file is removed since 4.14 and doesn't exist anymore. > >Previous PR is hung: https://github.com/openshift/must-gather/pull/429 >Please see this PR for lgtm from multus team. > >/assign @sferich888 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 months ago

@martinkennelly: This pull request references SDN-5066 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-33959, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/must-gather/pull/431): >Multus is now a Pod and will be captured by normal oc adm must-gather command. > >The multus.log file is removed since 4.14 and doesn't exist anymore. > >Previous PR is hung: https://github.com/openshift/must-gather/pull/429 >Please see this PR for lgtm from multus team. > >/assign @sferich888 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
martinkennelly commented 4 months ago

@sferich888 PTAL

sferich888 commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martinkennelly, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

@martinkennelly: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 months ago

@martinkennelly: Jira Issue OCPBUGS-33959: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33959 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/must-gather/pull/431): >Multus is now a Pod and will be captured by normal oc adm must-gather command. > >The multus.log file is removed since 4.14 and doesn't exist anymore. > >Previous PR is hung: https://github.com/openshift/must-gather/pull/429 >Please see this PR for lgtm from multus team. > >/assign @sferich888 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-must-gather This PR has been included in build ose-must-gather-container-v4.17.0-202407222110.p0.gd0ea87e.assembly.stream.el9. All builds following this will include this PR.

abhat commented 2 months ago

/cherry-pick release-4.17 release-4.16 release-4.15

openshift-cherrypick-robot commented 2 months ago

@abhat: new pull request could not be created: failed to create pull request against openshift/must-gather#release-4.17 from head openshift-cherrypick-robot:cherry-pick-431-to-release-4.17: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.17 and openshift-cherrypick-robot:cherry-pick-431-to-release-4.17"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to [this](https://github.com/openshift/must-gather/pull/431#issuecomment-2329847847): >/cherry-pick release-4.17 release-4.16 release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
abhat commented 2 months ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 2 months ago

@abhat: new pull request could not be created: failed to create pull request against openshift/must-gather#release-4.17 from head openshift-cherrypick-robot:cherry-pick-431-to-release-4.17: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.17 and openshift-cherrypick-robot:cherry-pick-431-to-release-4.17"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to [this](https://github.com/openshift/must-gather/pull/431#issuecomment-2329890331): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.