openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

RFE-5765: Collect etcd object count #435

Closed oarribas closed 1 month ago

oarribas commented 3 months ago

Collects the etcd object count in the etcd_info directory as json file.

oarribas commented 3 months ago

@davemulford , any thoughts on this?

sferich888 commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oarribas, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oarribas commented 1 month ago

Not sure why the jira/valid-reference label is missing, as this is linked to RFE-5765. Maybe RFEs are not valid as jira links?

oarribas commented 1 month ago

@sferich888 , @RickJWagner , can you check the missing jira/valid-reference label?

RickJWagner commented 1 month ago

Hi @oarribas Thank you for this PR. About the valid-reference label, could you please re-name this Issue Tracker so the RFE isn't contained in square brackets?
I've been looking over other PRs, I didn't find any others that were referencing JIRAs in square brackets. (There were some others that used the brackets, but these were used for release numbers.) If that doesn't work, we can ask Ben Parees, I think he's done a lot of the work in https://raw.githubusercontent.com/openshift-eng/jira-lifecycle-plugin/refs/heads/main/cmd/jira-lifecycle-plugin/server.go.

Please give it a shot, see if it works.

openshift-ci-robot commented 1 month ago

@oarribas: This pull request references RFE-5765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/must-gather/pull/435): >Collects the etcd object count in the `etcd_info` directory as `json` file. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 175ca71e11c09e79a4e357835699fc32e74c01d2 and 2 for PR HEAD 265f6d930e45c6bfea6d0cfe46c35e0f84535681 in total

openshift-ci[bot] commented 1 month ago

@oarribas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
oarribas commented 1 month ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 1 month ago

@oarribas: new pull request created: #453

In response to [this](https://github.com/openshift/must-gather/pull/435#issuecomment-2400023056): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
oarribas commented 1 month ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 1 month ago

@oarribas: new pull request created: #454

In response to [this](https://github.com/openshift/must-gather/pull/435#issuecomment-2400347561): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
oarribas commented 1 month ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 1 month ago

@oarribas: new pull request created: #456

In response to [this](https://github.com/openshift/must-gather/pull/435#issuecomment-2400349553): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
oarribas commented 1 month ago

/cherry-pick release-4.14

openshift-cherrypick-robot commented 1 month ago

@oarribas: new pull request created: #457

In response to [this](https://github.com/openshift/must-gather/pull/435#issuecomment-2400351524): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-must-gather This PR has been included in build ose-must-gather-container-v4.18.0-202410081810.p0.ga3ddf7f.assembly.stream.el9. All builds following this will include this PR.