search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 186 forks source link

CNF-13837: gather_ppc: fallback option when NTO image not found #436

Closed Tal-or closed 1 month ago

Tal-or commented 1 month ago

gather_ppc script is looking for NTO image, becuase it contains all the tools that are needed.

On Hypershift platfrom, the control-plane components are located on a different cluster, so the script can't find NTO image since the controller is running on the remote (management) cluster.

This commit suggests to add a fallback method: In case NTO deployment was not found, the script tries to get NTO image name from the release image.

Signed-off-by: Talor Itzhak titzhak@redhat.com

openshift-ci-robot commented 1 month ago

@Tal-or: This pull request references CNF-13837 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/must-gather/pull/436): >gather_ppc script is looking for NTO image, becuase it contains all the tools that needed. > >On Hypershift platfrom, the control-plane components are located on a different cluster, so the script can't find NTO image since the controller is running on the remote (management) cluster. > >This commit suggests to add a fallback method: >In case NTO deployment was not found, the script tries to get NTO image name from the release image. > >Signed-off-by: Talor Itzhak Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Tal-or commented 1 month ago

/cc @MarSik

MarSik commented 1 month ago

Apart from a tiny comment related to logging this is /lgtm

openshift-ci[bot] commented 1 month ago

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
MarSik commented 1 month ago

@sferich888 @RickJWagner Could you please take a look folks?

MarSik commented 1 month ago

/lgtm from me

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, RickJWagner, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [RickJWagner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-must-gather This PR has been included in build ose-must-gather-container-v4.17.0-202408012344.p0.g6598b16.assembly.stream.el9. All builds following this will include this PR.