search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

MON-3108: fix(collection-scripts/monitoring_common.sh): set a default --sandbox-dir-root to 'promtool tsdb dump-openmetrics' for better UX #437

Closed machine424 closed 3 months ago

machine424 commented 3 months ago

So users don't have to set it.

https://github.com/openshift/must-gather/pull/434 follow up.

This is a temporary fix until the upstream change is merged https://github.com/prometheus/prometheus/pull/14617 and shipped in OCP

See https://prometheus.io/docs/prometheus/latest/command-line/promtool/#promtool-tsdb-dump-openmetrics for the flag doc.

machine424 commented 3 months ago

cc @sferich888

openshift-ci[bot] commented 3 months ago

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sferich888 commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
machine424 commented 3 months ago

/retitle MON-3108: fix(collection-scripts/monitoring_common.sh): set a default --sandbox-dir-root to 'promtool tsdb dump-openmetrics' for better UX

openshift-ci-robot commented 3 months ago

@machine424: This pull request references MON-3108 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to [this](https://github.com/openshift/must-gather/pull/437): >So users don't have to set it. > >https://github.com/openshift/must-gather/pull/434 follow up. > >This is a temporary fix until the upstream change is merged https://github.com/prometheus/prometheus/pull/14617 and shipped in OCP > >See https://prometheus.io/docs/prometheus/latest/command-line/promtool/#promtool-tsdb-dump-openmetrics for the flag doc. > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-must-gather This PR has been included in build ose-must-gather-container-v4.18.0-202408132015.p0.g584b1ce.assembly.stream.el9. All builds following this will include this PR.