search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

OCPBUGS-10957: avoid monitoring routes and TLS #440

Closed jan--f closed 2 months ago

openshift-ci-robot commented 2 months ago

@jan--f: This pull request references Jira Issue OCPBUGS-10957, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/must-gather/pull/440): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jan--f commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@jan--f: This pull request references Jira Issue OCPBUGS-10957, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/must-gather/pull/440#issuecomment-2311962908): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zhouying7780 commented 2 months ago

@jan--f Since we have remove the define for 'CA_BUNDLE', we also need to remove it from cleanup() , because when I tested I hit : /usr/bin/gather_monitoring: line 26: CA_BUNDLE: unbound variable

jan--f commented 2 months ago

@jan--f Since we have remove the define for 'CA_BUNDLE', we also need to remove it from cleanup() , because when I tested I hit : /usr/bin/gather_monitoring: line 26: CA_BUNDLE: unbound variable

Fixed.

simonpasquier commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

@jan--f: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zhouying7780 commented 2 months ago

/label qe-approved

openshift-ci-robot commented 2 months ago

@jan--f: This pull request references Jira Issue OCPBUGS-10957, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/must-gather/pull/440): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 2 months ago

That looks nice, thank you /approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/master/collection-scripts/OWNERS)~~ [ardaguclu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@jan--f: Jira Issue OCPBUGS-10957: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10957 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/must-gather/pull/440): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-must-gather This PR has been included in build ose-must-gather-container-v4.18.0-202409021741.p0.g2d710fe.assembly.stream.el9. All builds following this will include this PR.