openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

[release-4.17] OCPBUGS-42958: Gather OSUS data #443

Closed openshift-cherrypick-robot closed 1 month ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #416

/assign oarribas

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OTA-1177

In response to [this](https://github.com/openshift/must-gather/pull/443): >This is an automated cherry-pick of #416 > >/assign oarribas Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ingvagabund commented 1 month ago

/approve /lgtm /label backport-risk-assessed

openshift-ci[bot] commented 1 month ago

@ingvagabund: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/must-gather/pull/443#issuecomment-2399220486): >/approve >/lgtm >/label backport-risk-assessed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ingvagabund commented 1 month ago

https://github.com/openshift/release/pull/57576 adding myself backport-risk-assessed permission

ingvagabund commented 1 month ago

/label backport-risk-assessed

ingvagabund commented 1 month ago

@oarribas you will still need @sferich888 to approve the PR as he's the only approver for 4.17 and down.

sferich888 commented 1 month ago

@ingvagabund we should fix that I am the only approver; but /lgtm

sferich888 commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, openshift-cherrypick-robot, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/release-4.17/collection-scripts/OWNERS)~~ [sferich888] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oarribas commented 1 month ago

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OTA-1177

@ingvagabund , @sferich888 , I think that could be the cause for the missing labels (and the same will also happen for backporting to older must-gather releases):

Not mergeable. Needs cherry-pick-approved, jira/valid-bug labels.

ingvagabund commented 1 month ago

Feel free to create a new OCPBUGS issue and retitle the PR. The bot should pick the changes right away.

oarribas commented 1 month ago

@ingvagabund , I created OCPBUGS-42958 [1] for this, but I cannot edit the tittle of this PR as it was created by the bot.

[1] https://issues.redhat.com/browse/OCPBUGS-42958

ingvagabund commented 1 month ago

/retitle [release-4.17] OCPBUGS-42958: Gather OSUS data

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42958, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/must-gather/pull/443): >This is an automated cherry-pick of #416 > >/assign oarribas Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ingvagabund commented 1 month ago

The current backporting process also requires you to create an OCPBUGS card for 4.18/master and link it with 4.17 card.

oarribas commented 1 month ago

Thanks @ingvagabund . I created OCPBUGS-42959 for 4.18 (not sure if the "Target version" needs to be 4.18 or 4.18.0.

Should I change also the tittle for #416 with OCPBUGS-42959? or is it enough to move that one to VERIFIED?

ingvagabund commented 1 month ago

The title can stay as it is. Now we just need to wait until OCPBUGS-42959 gets verified. 4.18.0 it is.

oarribas commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@oarribas: This pull request references Jira Issue OCPBUGS-42958, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.z) matches configured target version for branch (4.17.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-42959](https://issues.redhat.com//browse/OCPBUGS-42959) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-42959](https://issues.redhat.com//browse/OCPBUGS-42959) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/must-gather/pull/443#issuecomment-2407108589): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
oarribas commented 1 month ago

@ingvagabund , OCPBUGS-42959 is now Verified and the jira refreshed. Looks like it's still required to add the cherry-pick-approved label to this PR.

ingvagabund commented 1 month ago

@oarribas once the backport-risk-assessed label is set one of the QE engineers who can label a PR with cherry-pick-approved is added as a reviewer. @zhouying7780 in this case.

zhouying7780 commented 1 month ago

/label cherry-pick-approved

zhouying7780 commented 1 month ago

/label qe-approved

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42958, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.z) matches configured target version for branch (4.17.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-42959](https://issues.redhat.com//browse/OCPBUGS-42959) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-42959](https://issues.redhat.com//browse/OCPBUGS-42959) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/must-gather/pull/443): >This is an automated cherry-pick of #416 > >/assign oarribas Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42958: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42958 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/must-gather/pull/443): >This is an automated cherry-pick of #416 > >/assign oarribas Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-must-gather This PR has been included in build ose-must-gather-container-v4.17.0-202410121305.p0.gcd76726.assembly.stream.el9. All builds following this will include this PR.