search

openshift / must-gather

A client tool for gathering information about an operator managed component.
Apache License 2.0
104 stars 189 forks source link

OCPBUGS-43053: [Release-4.15] Network logs collection: skip unready nodes #447

Closed bpickard22 closed 1 month ago

bpickard22 commented 1 month ago

Previous to this change, debug pods will be launched to node that are unready and deployment will not complete.

Signed-off-by: Martin Kennelly mkennell@redhat.com (cherry picked from commit 619862a66621e17258c5b1d3d5048970987f1eb5)

openshift-ci[bot] commented 1 month ago

@bpickard22: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpickard22, RickJWagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[collection-scripts/OWNERS](https://github.com/openshift/must-gather/blob/release-4.15/collection-scripts/OWNERS)~~ [RickJWagner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ingvagabund commented 1 month ago

/label backport-risk-assessed

dougbtv commented 1 month ago

/retitle OCPBUGS-43053: [Release-4.15] Network logs collection: skip unready nodes

openshift-ci-robot commented 1 month ago

@bpickard22: This pull request references Jira Issue OCPBUGS-43053, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/must-gather/pull/447): >Previous to this change, debug pods will be launched to node that are unready and deployment will not complete. > >Signed-off-by: Martin Kennelly >(cherry picked from commit 619862a66621e17258c5b1d3d5048970987f1eb5) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@bpickard22: This pull request references Jira Issue OCPBUGS-43053. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to [this](https://github.com/openshift/must-gather/pull/447): >Previous to this change, debug pods will be launched to node that are unready and deployment will not complete. > >Signed-off-by: Martin Kennelly >(cherry picked from commit 619862a66621e17258c5b1d3d5048970987f1eb5) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmust-gather). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.