search

openshift / node-feature-discovery

Node feature discovery, detects the available hardware features and configuration in a cluster.
Apache License 2.0
15 stars 26 forks source link

[release-4.13] OCPBUGS-15096: move to golang.org/x/net v0.9.0 to fix CVE-2022-41717 and CVE-2022-41723 #109

Closed chr15p closed 1 year ago

chr15p commented 1 year ago

cherry-pick 559405d46d07058a0edeab399074a7f4a989b1ad from master to backport the cve fix into release-4.13

Original commit message: move to golang.org/x/net v0.9.0 to fix https://github.com/advisories/GHSA-xrjj-mj9h-534m and https://github.com/advisories/GHSA-7m5q-w7p8-x8h4

openshift-ci[bot] commented 1 year ago

@chr15p: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yevgeny-shnaidman commented 1 year ago

/lgtm

yevgeny-shnaidman commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chr15p, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/node-feature-discovery/blob/release-4.13/OWNERS)~~ [yevgeny-shnaidman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

@chr15p: This pull request references Jira Issue OCPBUGS-12520, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/109): >cherry-pick 559405d46d07058a0edeab399074a7f4a989b1ad from master to backport the cve fix into release-4.13 > >Original commit message: >move to golang.org/x/net v0.9.0 to fix https://github.com/advisories/GHSA-xrjj-mj9h-534m and https://github.com/advisories/GHSA-7m5q-w7p8-x8h4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chr15p commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@chr15p: This pull request references Jira Issue OCPBUGS-12520, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/109#issuecomment-1594813963): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chr15p commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@chr15p: This pull request references Jira Issue OCPBUGS-12520, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/109#issuecomment-1594815843): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@chr15p: This pull request references Jira Issue OCPBUGS-15096, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.z) matches configured target version for branch (4.13.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-15094](https://issues.redhat.com//browse/OCPBUGS-15094) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE)) * dependent [Jira Issue OCPBUGS-15094](https://issues.redhat.com//browse/OCPBUGS-15094) targets the "4.14.0" version, which is one of the valid target versions: 4.14.0 * bug has dependents

Requesting review from QA contact: /cc @wabouhamad

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/109): >cherry-pick 559405d46d07058a0edeab399074a7f4a989b1ad from master to backport the cve fix into release-4.13 > >Original commit message: >move to golang.org/x/net v0.9.0 to fix https://github.com/advisories/GHSA-xrjj-mj9h-534m and https://github.com/advisories/GHSA-7m5q-w7p8-x8h4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chr15p commented 1 year ago

sigh OCPBUGS-12520 does not target 4.13.0, it does targets 4.13.z but once openshift-ci-robot has looked at an issue it refuses to ever look at it again presumably because its catastrophically broken. The only work around is to raise a new issue and reference that instead so I created OCPBUGS-15096 to fix.

ybettan commented 1 year ago

@chr15p Can you try to re-push? Seems like tide changes aren't picked up for this PR.

yevgeny-shnaidman commented 1 year ago

@chr15p Can you try to re-push? Seems like tide changes aren't picked up for this PR.

@chr15p @ybettan no need for re-push, the tide changes are seen. All we need is staff-end-approve

ybettan commented 1 year ago

@chr15p @ybettan no need for re-push, the tide changes are seen. All we need is staff-end-approve

You are right. I was still seeing the "tide: no branch..." error yesterday. Probably takes some time to propagate.

openshift-ci-robot commented 1 year ago

@chr15p: Jira Issue OCPBUGS-15096: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15096 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/109): >cherry-pick 559405d46d07058a0edeab399074a7f4a989b1ad from master to backport the cve fix into release-4.13 > >Original commit message: >move to golang.org/x/net v0.9.0 to fix https://github.com/advisories/GHSA-xrjj-mj9h-534m and https://github.com/advisories/GHSA-7m5q-w7p8-x8h4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 year ago

[ART PR BUILD NOTIFIER]

This PR has been included in build node-feature-discovery-container-v4.13.0-202311211131.p0.g79c2147.assembly.stream for distgit node-feature-discovery. All builds following this will include this PR.