search

openshift / node-feature-discovery

Node feature discovery, detects the available hardware features and configuration in a cluster.
Apache License 2.0
14 stars 26 forks source link

OCPBUGS-28751: fixing incorrect import path #127

Closed yevgeny-shnaidman closed 9 months ago

yevgeny-shnaidman commented 9 months ago

source/kernel/module.go code was importing the upstream package of hostpath instead of downstream package

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/node-feature-discovery/blob/release-4.14/OWNERS)~~ [yevgeny-shnaidman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 9 months ago

@yevgeny-shnaidman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yevgeny-shnaidman commented 9 months ago

/label backport-risk-assessed

chr15p commented 9 months ago

/lgtm

yevgeny-shnaidman commented 9 months ago

/label jira/valid-bug

openshift-ci[bot] commented 9 months ago

@yevgeny-shnaidman: Can not set label jira/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight]

In response to [this](https://github.com/openshift/node-feature-discovery/pull/127#issuecomment-1919349387): >/label jira/valid-bug Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 9 months ago

@yevgeny-shnaidman: This pull request references Jira Issue OCPBUGS-28751, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/127): >source/kernel/module.go code was importing the upstream package of hostpath instead of downstream package Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fnode-feature-discovery). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yevgeny-shnaidman commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@yevgeny-shnaidman: This pull request references Jira Issue OCPBUGS-28751, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/127#issuecomment-1919380593): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fnode-feature-discovery). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yevgeny-shnaidman commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@yevgeny-shnaidman: This pull request references Jira Issue OCPBUGS-28751, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/127#issuecomment-1919384869): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fnode-feature-discovery). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yevgeny-shnaidman commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@yevgeny-shnaidman: This pull request references Jira Issue OCPBUGS-28751, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/127#issuecomment-1919386690): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fnode-feature-discovery). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yevgeny-shnaidman commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@yevgeny-shnaidman: This pull request references Jira Issue OCPBUGS-28751, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/127#issuecomment-1919387733): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fnode-feature-discovery). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yevgeny-shnaidman commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@yevgeny-shnaidman: This pull request references Jira Issue OCPBUGS-28751, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-28752](https://issues.redhat.com//browse/OCPBUGS-28752) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-28752](https://issues.redhat.com//browse/OCPBUGS-28752) targets the "4.15.0" version, which is one of the valid target versions: 4.15.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ggordani@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/127#issuecomment-1919388965): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fnode-feature-discovery). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ggordaniRed commented 9 months ago

/label cherry-pick-approved

openshift-ci-robot commented 9 months ago

@yevgeny-shnaidman: Jira Issue OCPBUGS-28751: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28751 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/127): >source/kernel/module.go code was importing the upstream package of hostpath instead of downstream package Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fnode-feature-discovery). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 9 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build node-feature-discovery-container-v4.14.0-202402010839.p0.gf80e9a5.assembly.stream for distgit node-feature-discovery. All builds following this will include this PR.