search

openshift / node-feature-discovery

Node feature discovery, detects the available hardware features and configuration in a cluster.
Apache License 2.0
14 stars 26 forks source link

OCPBUGS-26652: update go.mod & vendor for 4.13 (SAST scanning) #131

Open chr15p opened 7 months ago

chr15p commented 7 months ago

This will fix most of the SAST security scanner results reported in OCPBUGS-26652 by updating go.mod and the vendor directory to the versions used in 4.16.

It will still leave at least one SAST reported error in the hooks code open, that should be fixed in a future PR

openshift-ci-robot commented 7 months ago

@chr15p: This pull request references Jira Issue OCPBUGS-26652, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/131): >This will fix most of the SAST security scanner results reported in [OCPBUGS-26652](https://issues.redhat.com/browse/OCPBUGS-26652) by updating go.mod and the vendor directory to the versions used in 4.16. > >It will still leave at least one SAST reported error in the hooks code open, that should be fixed in a future PR Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fnode-feature-discovery). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chr15p Once this PR has been reviewed and has the lgtm label, please assign yevgeny-shnaidman for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/node-feature-discovery/blob/release-4.13/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chr15p commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@chr15p: This pull request references Jira Issue OCPBUGS-26652, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/131#issuecomment-2045150909): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fnode-feature-discovery). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
chr15p commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@chr15p: This pull request references Jira Issue OCPBUGS-26652, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/node-feature-discovery/pull/131#issuecomment-2157622808): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fnode-feature-discovery). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
chr15p commented 4 months ago

/retest

openshift-ci[bot] commented 4 months ago

@chr15p: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit c650fe8894c6d3ab9ad533a7ecf6aaa8d0dc5cf9 link true /test unit
ci/prow/images c650fe8894c6d3ab9ad533a7ecf6aaa8d0dc5cf9 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 1 week ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale