search

openshift / node-feature-discovery

Node feature discovery, detects the available hardware features and configuration in a cluster.
Apache License 2.0
14 stars 26 forks source link

[MGMT-12444] NFD does not properly detect AMD processors #97

Closed chr15p closed 2 years ago

chr15p commented 2 years ago

the github.com/klauspost/cpuid/v2 library added AMD SVM feature support in v2.1.0 (https://github.com/klauspost/cpuid/releases/tag/v2.1.0) it also added AMD SEV/SME support in 2.0.13

NFD4.11 uses v2.0.9, and the NFD4.12 branch uses v2.0.11, NFD upstream master uses v2.1.0.

This commit brings this repo in line with upstream by moving to github.com/klauspost/cpuid/v2 v2.1.0 to add support for labeling nodes as having support for these AMD features.

openshift-ci[bot] commented 2 years ago

@chr15p: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yevgeny-shnaidman commented 2 years ago

/approve

yevgeny-shnaidman commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chr15p, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/node-feature-discovery/blob/master/OWNERS)~~ [yevgeny-shnaidman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chr15p commented 2 years ago

/cherrypick release-4.12

openshift-cherrypick-robot commented 2 years ago

@chr15p: new pull request created: #98

In response to [this](https://github.com/openshift/node-feature-discovery/pull/97#issuecomment-1313807625): >/cherrypick release-4.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.