openshift / oadp-operator

OADP Operator
Apache License 2.0
77 stars 70 forks source link

[oadp-1.4] OADP-4379: read ephemeral-storage in code #1491

Closed mateusoliveira43 closed 1 month ago

mateusoliveira43 commented 1 month ago

Why the changes were made

cherry picked from commit https://github.com/openshift/oadp-operator/commit/b51ce21d3df79005a81ed6e579a3359cffa46b0f : PR https://github.com/openshift/oadp-operator/pull/1477

How to test the changes made

Follow instructions from parent PR.

openshift-ci-robot commented 1 month ago

@mateusoliveira43: This pull request references OADP-4379 which is a valid jira issue.

In response to [this](https://github.com/openshift/oadp-operator/pull/1491): >## Why the changes were made > >cherry picked from commit https://github.com/openshift/oadp-operator/commit/b51ce21d3df79005a81ed6e579a3359cffa46b0f : PR https://github.com/openshift/oadp-operator/pull/1477 > >## How to test the changes made > >Follow instructions from parent PR. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foadp-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
mateusoliveira43 commented 1 month ago

/retest

mateusoliveira43 commented 1 month ago

/retest infra and post restore flake

mateusoliveira43 commented 1 month ago

/retest

mateusoliveira43 commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oadp-operator/blob/oadp-1.4/OWNERS)~~ [shubham-pampattiwar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
weshayutin commented 1 month ago

/retest

weshayutin commented 1 month ago

hrm... this doesn't seem like a "flake" more like build / containers aren't right, but unrelated to this patch.

mateusoliveira43 commented 1 month ago

/retest

mateusoliveira43 commented 1 month ago

/retest

mateusoliveira43 commented 1 month ago

/retest

mateusoliveira43 commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@mateusoliveira43: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
shubham-pampattiwar commented 1 month ago

/lgtm