openshift / oadp-operator

OADP Operator
Apache License 2.0
77 stars 70 forks source link

Bump up CirrOS image size for PSI. #1495

Closed mrnold closed 1 month ago

mrnold commented 1 month ago

Why the changes were made

Importing the CirrOS image into a cluster on OpenStack (storage class ocs-storagecluster-ceph-rbd-virtualization) fails with Virtual image size 117440512 is larger than the reported available storage 117317632. A larger PVC is required.

I'm not sure why this is the case, but bumping it up from 128M to 150 works.

How to test the changes made

E2E tests are not set up to run against OpenStack just yet, but hacking it up to do nothing but download the CirrOS image reproduces the bug and the fix. You can also create the Data Volume manually:

---
apiVersion: cdi.kubevirt.io/v1beta1
kind: DataVolume
metadata:
  name: cirros
  namespace: openshift-virtualization-os-images
spec:
  pvc:
    accessModes:
    - ReadWriteOnce
    resources:
      requests:
        storage: 150Mi
  source:
    http:
      url: https://download.cirros-cloud.net/0.6.2/cirros-0.6.2-x86_64-disk.img
mrnold commented 1 month ago

/test 4.16-e2e-test-aws

mrnold commented 1 month ago

/test 4.16-e2e-test-aws

mrnold commented 1 month ago

/test 4.16-e2e-test-aws

mrnold commented 1 month ago

/test 4.16-e2e-test-aws

mrnold commented 1 month ago

/test 4.16-e2e-test-aws

mrnold commented 1 month ago

/test 4.16-e2e-test-aws

mrnold commented 1 month ago

/test 4.16-e2e-test-aws

mrnold commented 1 month ago

/test 4.16-e2e-test-aws

mrnold commented 1 month ago

/test 4.16-e2e-test-aws

openshift-ci[bot] commented 1 month ago

@mrnold: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kaovilai commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mrnold, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/e2e/OWNERS](https://github.com/openshift/oadp-operator/blob/master/tests/e2e/OWNERS)~~ [kaovilai,mrnold,shubham-pampattiwar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
weshayutin commented 1 month ago

/cherry-pick oadp-1.4

openshift-cherrypick-robot commented 1 month ago

@weshayutin: #1495 failed to apply on top of branch "oadp-1.4":

Applying: Bump up CirrOS image size for PSI.
Using index info to reconstruct a base tree...
M   tests/e2e/virt_backup_restore_suite_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/virt_backup_restore_suite_test.go
CONFLICT (content): Merge conflict in tests/e2e/virt_backup_restore_suite_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bump up CirrOS image size for PSI.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/oadp-operator/pull/1495#issuecomment-2302445098): >/cherry-pick oadp-1.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.